Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul example with more information and CI #1

Merged
merged 14 commits into from
Jul 26, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jul 15, 2022

As part of my process to complete pytroll/satpy#2138 I'm updating this repository with more information. In this PR I've:

  1. Added more information to the README on how to install the package, what the contents are, how to contribute, and where the Satpy plugin documentation is.
  2. Added GitHub Actions CI
  3. Added a .gitignore
  4. Added more standard information to the setup.py for now. See below.

TODO

I still plan on replacing the setup.py with a pyproject.toml.

@djhoese djhoese added the enhancement New feature or request label Jul 15, 2022
@djhoese djhoese requested a review from mraspaud July 15, 2022 19:41
@djhoese djhoese self-assigned this Jul 15, 2022
@djhoese
Copy link
Member Author

djhoese commented Jul 15, 2022

@djhoese
Copy link
Member Author

djhoese commented Jul 16, 2022

I switched to pyproject.toml completely but it turns out pip/setuptools don't work with editable installs so the tests fail. At least, they will until pypa/setuptools#2816 is resolved.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the licencing, otherwise looks good, thanks for the cleanup!

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mraspaud mraspaud merged commit 105a87f into pytroll:main Jul 26, 2022
@djhoese djhoese deleted the overhaul branch July 26, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants