Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin functionality for readers, writers, and enhancements #2138

Merged
merged 20 commits into from
Jul 26, 2022

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Jul 7, 2022

It was already possible to define a Satpy plugin package for composites (and therefore modifiers). This PR adds the ability to use that functionality for other components.

  • Closes #xxxx
  • Tests added
  • Fully documented

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #2138 (5720b0a) into main (15dbf3d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2138      +/-   ##
==========================================
+ Coverage   93.88%   93.91%   +0.02%     
==========================================
  Files         283      283              
  Lines       43123    43258     +135     
==========================================
+ Hits        40488    40626     +138     
+ Misses       2635     2632       -3     
Flag Coverage Δ
behaviourtests 4.78% <2.59%> (-0.01%) ⬇️
unittests 94.56% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/multiscene.py 91.90% <ø> (ø)
satpy/composites/config_loader.py 93.15% <100.00%> (+1.57%) ⬆️
satpy/readers/__init__.py 97.53% <100.00%> (+0.01%) ⬆️
satpy/tests/conftest.py 100.00% <100.00%> (ø)
satpy/tests/test_composites.py 100.00% <100.00%> (ø)
satpy/tests/test_config.py 97.08% <100.00%> (+2.46%) ⬆️
satpy/writers/__init__.py 88.59% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@coveralls
Copy link

coveralls commented Jul 7, 2022

Coverage Status

Coverage increased (+0.02%) to 94.508% when pulling 5720b0a on djhoese:doc-plugin-config into 15dbf3d on pytroll:main.

@djhoese djhoese marked this pull request as ready for review July 17, 2022 19:52
@djhoese djhoese requested a review from mraspaud as a code owner July 17, 2022 19:52
@djhoese djhoese requested a review from gerritholl July 17, 2022 19:52
@djhoese
Copy link
Member Author

djhoese commented Jul 17, 2022

See pytroll/satpy-composites-plugin-example#1 for the updated example repository.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! A few questions and suggestions for improvement.

doc/source/dev_guide/plugins.rst Show resolved Hide resolved
doc/source/dev_guide/plugins.rst Show resolved Hide resolved
doc/source/dev_guide/plugins.rst Outdated Show resolved Hide resolved
doc/source/dev_guide/plugins.rst Show resolved Hide resolved
doc/source/dev_guide/plugins.rst Outdated Show resolved Hide resolved
doc/source/dev_guide/plugins.rst Outdated Show resolved Hide resolved
doc/source/dev_guide/plugins.rst Outdated Show resolved Hide resolved
doc/source/dev_guide/plugins.rst Outdated Show resolved Hide resolved
doc/source/dev_guide/plugins.rst Outdated Show resolved Hide resolved
doc/source/remote_reading.rst Show resolved Hide resolved
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit dea932d into pytroll:main Jul 26, 2022
@djhoese djhoese deleted the doc-plugin-config branch July 26, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants