Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Replace data: URI's in CSS with custom URL's #123

Closed
kbhomes opened this issue Apr 7, 2014 · 0 comments
Closed

Replace data: URI's in CSS with custom URL's #123

kbhomes opened this issue Apr 7, 2014 · 0 comments
Milestone

Comments

@kbhomes
Copy link
Member

kbhomes commented Apr 7, 2014

As recently implemented in the fix for the inverted sprite sheet, a new NSURLProtocol could be implemented that looks in the images folder of the bundle in order to load an image. For example, url(http://radiant-player-mac/lastfm.png) would go through an NSURLProtocol which sends back the contents of images/lastfm.png. This would significantly streamline the process of getting images into custom CSS.

@kbhomes kbhomes added this to the v1.1.3 milestone Apr 7, 2014
@kbhomes kbhomes closed this as completed in d2ce93a Apr 7, 2014
kbhomes added a commit that referenced this issue Apr 7, 2014
* master: (24 commits)
  Fix mini player location at edge of screen, multiple screens (fixes #108)
  Use an NSURLProtocol instead of data: URIs (fixes #123)
  Tweak preferences window height
  Fix notifications on Safari 6/OS X 10.8 (fixes #92)
  Fix CSS for Safari 6 and OS X 10.8 (fixes #91)
  Fix mini player to work on OS X 10.8 (fixes #106)
  Modify dark.css, CustomWebView to use/hold inverted sprite sheet (fixes #90, #120)
  Revert event tap creation, fixes QuickLook but breaks Fireworks (fixes #117)
  Remember last size of mini player (fixes #96)
  Revert "Fix timestamp alignment in Last.fm popover"
  Fix timestamp alignment in Last.fm popover
  Update Last.fm API keys
  Add preference to automatically love/unlove a track on Last.fm based on thumbs up rating (fixes #83)
  Add preference for showing the Last.fm button
  Add ability to love/unlove song from Last.fm popover
  Append Last.fm icon instead of replacing other links
  Add Last.fm popover that shows 10 most recent tracks
  Add NSDate+TimeAgo to podfile
  Update Last.fm icon in preferences
  Fix album title color in dark style (fixes #101, thanks @Deanmv)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant