Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Love on last.fm #83

Closed
webbson opened this issue Mar 19, 2014 · 1 comment
Closed

Love on last.fm #83

webbson opened this issue Mar 19, 2014 · 1 comment
Labels
enhancement
Milestone
v1.1.3

Comments

@webbson
Copy link

webbson commented Mar 19, 2014

Ability to love a track on last.fm, either automatically on "thumbs up" vote or via seperate button.
@kbhomes kbhomes modified the milestone: v1.1.3 Mar 24, 2014
@kbhomes kbhomes closed this as completed in f1c4bbf Apr 3, 2014
@kbhomes
Copy link
Member

kbhomes commented Apr 3, 2014

Integrated! This one's a pretty big change and warrants some further testing, but here's what's been changed.

There's a new preference to automatically love a track if the track is rated "thumbs up" on Google Play Music, which also unloves the track if it is no longer "thumbs up". Most prominently, there is a new button on the main window (also behind a preference) that opens a popover showing the most 10 most recent tracks + now playing track on Last.fm, so you can always confirm that your songs are being scrobbled properly, as well as allowing you to love or unlove a track by clicking the heart.

Here's a preview:

Last.fm popover

I'd love to get feedback on this new feature from anybody who extensively uses Last.fm.

kbhomes added a commit that referenced this issue Apr 7, 2014
@kbhomes
Merge branch 'master' into pr/105
24caf71 
* master: (24 commits)
  Fix mini player location at edge of screen, multiple screens (fixes #108)
  Use an NSURLProtocol instead of data: URIs (fixes #123)
  Tweak preferences window height
  Fix notifications on Safari 6/OS X 10.8 (fixes #92)
  Fix CSS for Safari 6 and OS X 10.8 (fixes #91)
  Fix mini player to work on OS X 10.8 (fixes #106)
  Modify dark.css, CustomWebView to use/hold inverted sprite sheet (fixes #90, #120)
  Revert event tap creation, fixes QuickLook but breaks Fireworks (fixes #117)
  Remember last size of mini player (fixes #96)
  Revert "Fix timestamp alignment in Last.fm popover"
  Fix timestamp alignment in Last.fm popover
  Update Last.fm API keys
  Add preference to automatically love/unlove a track on Last.fm based on thumbs up rating (fixes #83)
  Add preference for showing the Last.fm button
  Add ability to love/unlove song from Last.fm popover
  Append Last.fm icon instead of replacing other links
  Add Last.fm popover that shows 10 most recent tracks
  Add NSDate+TimeAgo to podfile
  Update Last.fm icon in preferences
  Fix album title color in dark style (fixes #101, thanks @Deanmv)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.1.3
Development

No branches or pull requests
2 participants
@kbhomes @webbson