Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better integrate common metadata #1208

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Better integrate common metadata #1208

merged 2 commits into from
Apr 13, 2023

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Jan 5, 2023 •
edited
Loading

Related Issue(s): #1199 #1187

Proposed Changes:

  1. Validate common metadata also in Catalogs, Collections and Links. Also, re-uses the schemas from common metadata in Collections so that they don't diverge (which was the case).
  2. Includes a very minor somewhat breaking change: Provider, Asset and Item descriptions can't be empty now. Either they need to be omitted or contain at least one character. This aligns with Catalog and Collection description as part of the common metadata model.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr added this to the 1.1 milestone Jan 5, 2023
@m-mohr m-mohr force-pushed the common-metadata-json-validation branch from 8629e94 to 5afd50d Compare January 5, 2023 11:35
@m-mohr m-mohr force-pushed the common-metadata-json-validation branch from 5afd50d to 54a8cb8 Compare January 5, 2023 11:36
@m-mohr m-mohr linked an issue Jan 5, 2023 that may be closed by this pull request
Being able to use common metadata dates in collection #1199
Closed
m-mohr
m-mohr commented Jan 5, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@m-mohr m-mohr merged commit 86b9403 into dev Apr 13, 2023
@m-mohr m-mohr deleted the common-metadata-json-validation branch April 13, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhanson matthewhanson matthewhanson approved these changes

@cholmes cholmes cholmes approved these changes

@jbants jbants Awaiting requested review from jbants

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0-beta.1
Development

Successfully merging this pull request may close these issues.

Being able to use common metadata dates in collection
3 participants
@m-mohr @cholmes @matthewhanson