Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #55, two tests have been failing when running locally. Investigation has shown that the
change
event handler inbindInputPanel
is not called. Despite the tests waiting twice the debouncing delay, the debounced function is not called.The root cause of the test failures is the fake timers are not applying to the
now()
call in thedebounce
library. Based on the docs for fake timers, callingsinon.useFakeTimers()
should:After calling
clock.tick(ms)
we should seems
, but instead we get the currenttimestamp
(below highlighted variable on mid left):Changing the order of the imports ensures that
debounce
anddate-now
use the fake timers, and the tests pass. With the changes in this PR, notice how thetimestamp
is our value forclock.tick(ms)
:Those failing tests pass: