Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate dependency on Velocity #4441

Closed
spencern opened this issue Jul 16, 2018 · 3 comments · Fixed by #4599
Closed

Eliminate dependency on Velocity #4441

spencern opened this issue Jul 16, 2018 · 3 comments · Fixed by #4599
Assignees

Comments

@spencern
Copy link
Contributor

spencern commented Jul 16, 2018

Issue Description

We currently have a dependency on Velocity for animating parts of our client application.
Velocity is a DOM animation library which makes doing some complex animations performant and simple.
We currently use velocity to do one of two things.

  1. Animate the cart drawer opacity
  2. Animate the background color of changed fields from green and then back to white.

Neither of these animations should need a library to do well or simply and don't justify the added overhead of 94.5kb

The animations using velocity are contained in one of 6 files

  • containers/cartIconContainer.js
  • components/metadata/metafield.js
  • components/tagItem.js
  • components/productAdmin.js
  • components/productField.js
  • components/variantForm.js

This issue is to eliminate the dependency on Velocity and replace any animations that are using Velocity with another method of animation.

@dancastellon
Copy link
Contributor

@zenweasel Does it make sense to try CSS animations or is jQuery fine?

@brent-hoover
Copy link
Collaborator

@dancastellon No jQuery ever.

@spencern
Copy link
Contributor Author

Animating with Javascript is fine though, I created this ticket because I don't think the type of animations we're performing warrant an animation library. Honestly this is not a high priority if it turns out to be a tough task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants