Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version of velocity-react to 1.4.1 #4442

Closed
wants to merge 1 commit into from

Conversation

spencern
Copy link
Contributor

Impact: minor
Type: chore

Issue

The version of velocity-react we've been using is out of date and depends on an old version of lodash which has a snyk reported medium severity vulnerability.

Solution

This bumps the version of velocity-react to the latest version which includes updating the lodash dependency

Breaking changes

none

Notes

There are only 6 places in the app that we use Velocity and it's a heavier package. It would be ideal to eliminate the dependency on this package entirely and animate using CSS transitions where possible or eliminate complex animations requiring a package like this from core. That task has been created as a ticket here: #4441

Testing

The animations using velocity are contained in one of 6 files

  • containers/cartIconContainer.js
  • components/metadata/metafield.js
  • components/tagItem.js
  • components/productAdmin.js
  • components/productField.js
  • components/variantForm.js

@spencern spencern requested a review from willopez July 16, 2018 20:52
@spencern spencern added this to the Isolation milestone Jul 16, 2018
@spencern
Copy link
Contributor Author

This is replaced by #4444

@spencern spencern closed this Jul 17, 2018
@aldeed aldeed deleted the spencer-update-velocity-react branch July 21, 2018 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant