(refactor): 4263 nnnnat non meteor schemas #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons dir, removed the meteor check and tracker from the schemas, created a new lib/comllections/schemas/index.js that imports the schemas for meteor and adds the check and tracker to the schemas
…ts collections, removed the shopIdAutoValue call from the Accounts schema
…rom the Tag schema
…hopIdAutoValue from Shipping schema
…oValue from Cart and CartItem schema
… shopIdAutoValue from the Products schema
…Id to discounts inserts
…o taxes collection inserts
…tual schema export
…opId to data, updated usage
nnnnat
changed the title
…n and not lazyLoad between the two options, updated shops and products schema to not use autovalues when creating slugs, updated fixtures and inserts to set slugs on shops and products
…s call to prevent an endless loop, updated importer to check the cbArgs in the process method and added jsdoc for the new arg
nnnnat
changed the title
kieckhafer
reviewed
May 25, 2018
| */ | ||
|
|
||
| /** | ||
| * Reaction uses {@link https://github.com/aldeed/simple-schema-js SimpleSchema} to apply basic content and structure validation to Collections. |
There was a problem hiding this comment.
Do we need both of these jsdoc blocks?
There was a problem hiding this comment.
I think so, I believe @aldeed did this when he cleaned up the jsdoc a few months back
kieckhafer
reviewed
May 25, 2018
| const product = { | ||
| title: faker.commerce.productName(), | ||
| title: productTitle, |
There was a problem hiding this comment.
All the other fields are being populated on the fly here, why move the productTitle into it's own const?
There was a problem hiding this comment.
Nevermind... didn't see it was being used in the handle
kieckhafer
approved these changes
May 25, 2018
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4263
Impact: breaking
Type: refactor
Issue
Move/change the lib/collections/schemas files so that we can get access to schemas in devserver/Jest tests without a Meteor context.
Solution
lib/collections/schemasand intoimports/collections/schemasmeteor/checkandmeteor/Trackerfrom each schema contructor.shopIdAutoValue,shopIdAutoValueForCartandshopDefaultCountryautoValue functions from schemas in favor of explicitly setting those values on collectioninsert.lib/collections/schemas/index.jsto import the non-meteor schemas and add themeteor/checkandmeteor/Trackerto the schema's constructor for use inside the meteor application.shopIdAutoValuefrom plugin schemas and updated usage to provide ashopIdon collectioninsertserver/api/core/utils.js getSlugmethod to just import transliteration by default and removed theautoValuefunctions being used in schema constructors in favor of setting theslug/handleon collection inserts./lib/collections/schema/index.jsand not the schema files.Breaking changes
The schemas have moved, we're still importing them inside the
lib/collections/schemas/index.jsto apply themeteor/checkandmeteor/Trackerto the schemas when being used with meteor. I don't believe this is a breaking change necessarily but I wanted to outline it.Aside from
createdAtAutoValueandupdatedAtAutoValuewe're moving away from using autoValues in the schemas in favor of providing required properties.shopIdAutoValue,shopIdAutoValueForCartandshopDefaultCountryautoValue helper functions will no longer be available.If you have custom plugins that are inserting into any collection that has a
shopIdproperty, and you rely onshopIdbeing automatically set, you will now have to explicitly set it yourself in the inserted object.Testing
You may need to rebuild your docker image for this branch to work