(feat): 4246 nnnnat new mocks factory #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the tags schema and integration test as a demo
…nat-new-mocks-factory
…il file that adds mock factories from our schemas
… all test are failing because the mongo cursors chnage on every run
… a mocks custom property
…tAdmin container in favor of doing it on the server, updated createProduct util fruntion for create a random handle when new products are created
…uct has a child variant, created hasChildVariant test
…schema, added Error check for invalid inventoryQuantity when updating product fields
… getSlug helper func in the server/shop methods
nnnnat
changed the title
nnnnat
changed the title
nnnnat
changed the title
aldeed
requested changes
Jun 4, 2018
There was a problem hiding this comment.
A few minor inline comments, but everything looks good in testing. Specifically
- Created and published product. New product has default handle
- Updated handle. The entered value is properly slugified
- Made sure I can't submit an empty inventory quantity when inventory tracking is enabled
| @@ -0,0 +1,7 @@ | |||
| import SimpleSchema from "simpl-schema"; | |||
|
|
|||
| SimpleSchema.extendOptions([ | |||
There was a problem hiding this comment.
Add a comment above this since it might not be obvious why.
// These options are added by the `aldeed:schema-index` Meteor package, but because that
// is a Meteor package and we also load the schemas in a non-Meteor Node app, we need to do it here.
| /** | ||
| * | ||
| * @method hasChildVariant | ||
| * @summary Return true if a Product or Variant has at least 1 child Product. |
There was a problem hiding this comment.
Add to the end of summary: "that is visible and not deleted"
| mockCollections.Products.findOne.mockReturnValueOnce(Promise.resolve(mockVariants[1])); | ||
| const spec = await hasChildVariant(internalVariantIds[0], mockCollections); | ||
| expect(spec).toBe(true); | ||
| }); |
There was a problem hiding this comment.
Because you're mocking the findOne, this test isn't really any different from the one above it. I'd just go with the two tests, true and false.
If you wanted to actually test the findOne selector, you'd have to make some integration tests for it. I don't think that's necessary since it's a simple function.
|
@aldeed I've made the requested changes and it's ready for review. |
aldeed
approved these changes
Jun 4, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4246
Impact: minor
Type: feature|refactor
Issue
Writing GQL integration test has become difficult because we've been creating mock data ad-hoc.
More info here
Solution
@reactioncommercenpm package that can take the de-meteorizedSimpleSchemaand create a mocks factory for each schema. See data-factorytest-utils/helperthat will build a mocks factory using the data-factory package and export aFactoryobject to be used in the integration test.Factory.Breaking changes
ReactionProductAPI fromlib/apiTesting
docker-compose run devserver npm run test:integration