-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recreating flyout as a webcomponent #86
Conversation
I did a quick QA locally and it's looking great! 💯 . I'm super excited about this work and I'd like to deploy it soon and start testing it on production 👍🏼 . @zanderle what's the status of it? Is it ready for review? If not, what are you considering it's missing currently? |
Return `addons.flyout.translations` and `addons.flyout.downloads`. Remove `addons.flyout.vcs` for now because we don't have a reliable way to implement it without injecting data into the build which we don't want to do anymore. Related readthedocs/addons#86
@humitos yeah, the first version is ready. One thing I am unsure about is the fact that we're grabbing the versions from Additionally, this is important so we can mark the current version in the versions list. We could compare with Other than that, this is still a v1 of the flyout. I'm wondering if it's ok that the input to the webcomponent is the "global" config (with all the addons, and everything", or if it should be just the |
@zanderle good points raised here! Originally, I thought that the whole config will be the input for each of the addons. This is because "the current version" for example, is something that more than one addon will require. So, I moved those "shared data" into an upper level and keep the data that is only required for the particular addon under Besdies, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some small commits with simple tweaks since I want to deploy this tomorrow, together with readthedocs/readthedocs.org#10650 If there are extra changes here, we can open new PRs. |
I'm gonna merge this since I want to deploy it today to start testing it. |
* Addons: prepare the backend for the new flyout Return `addons.flyout.translations` and `addons.flyout.downloads`. Remove `addons.flyout.vcs` for now because we don't have a reliable way to implement it without injecting data into the build which we don't want to do anymore. Related readthedocs/addons#86 * Addons: create one feature flag per addon This allows us to have full control over each project. * Addons: decide whether or not enable the addon via feature flag * Test: update response for Addons V0 * Typo * Flyout: don't show hidden versions
Building on top of the work started in #66
Closes #70