Addons: prepare the backend for the new flyout #10650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return `addons.flyout.translations` and `addons.flyout.downloads`. Remove `addons.flyout.vcs` for now because we don't have a reliable way to implement it without injecting data into the build which we don't want to do anymore. Related readthedocs/addons#86
humitos
commented
Aug 26, 2023
This allows us to have full control over each project.
|
This PR also introduces one feature flag per addon. This allows us to disable the addon on projects with problems or we consider useful for testing purposes. |
|
I'm going to deploy this tomorrow because I want to start testing the new flyout addon. |
|
Hrm... Tests are broken on |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
addons.flyout.translationsandaddons.flyout.downloads. Removeaddons.flyout.vcsfor now because we don't have a reliable way to implement it without injecting data into the build which we don't want to do anymore.