-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxito: deprecate serving README.html
by default
#9993
Labels
Needed: design decision
A core team decision is required
Comments
We have 340 projects in .org and 1 in .com relying on this https://onenr.io/0BQ1Gv2BMRx |
Count has gone down in the last year: 239 |
Cool. I checked this today and we have 227. |
humitos
added a commit
to readthedocs/website
that referenced
this issue
May 23, 2024
humitos
added a commit
that referenced
this issue
May 23, 2024
humitos
added a commit
that referenced
this issue
May 23, 2024
humitos
added a commit
to readthedocs/website
that referenced
this issue
May 27, 2024
* Post: redirecting `/` to `README.html` deprecation Related readthedocs/readthedocs.org#9993 * Small change * Add tip * Send email on Tuesday * Update content/posts/readme-html-deprecated.md Co-authored-by: Eric Holscher <[email protected]> --------- Co-authored-by: Eric Holscher <[email protected]>
Email sent today. |
humitos
added a commit
that referenced
this issue
May 29, 2024
* Proxito: browndate for redirecting `/` to `README.html` Related #9993 * Rename function to make it clearer * Keep indexing README.html for now * Update logic to take into account enforce brownout setting
Work done in #11348 |
humitos
added a commit
that referenced
this issue
Jul 1, 2024
Fully removal after deprecation and browndates. Reference: * #9993 * #11348 * https://about.readthedocs.com/blog/2024/05/readme-html-deprecated/
humitos
added a commit
that referenced
this issue
Jul 11, 2024
* Proxito: remove redirect for `README.html` files Fully removal after deprecation and browndates. Reference: * #9993 * #11348 * https://about.readthedocs.com/blog/2024/05/readme-html-deprecated/ * Simplify the logic for tryfiles on El Proxito * Add missing case * Remove README from the docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are currently serving
/README.html
and<path>/README.html
inreadthedocs.org/readthedocs/proxito/views/serve.py
Lines 301 to 327 in e85ee7d
This is not a standard behavior and we have it there because of pretty old compatibility reasons. I'd like to deprecate this and remove this "feature" if possible. As a first step, I added the
tryfile=
argument in the log line in #9983 to start tracking this and check how many projects are using this non-standard hosting feature. We can then check this via New Relic, analyze and decide what to do.The text was updated successfully, but these errors were encountered: