Proxito: browndate for redirecting / to README.html
#11348
Conversation
readthedocs/projects/tasks/search.py
Outdated
| if allow_readme_html_at_root_url(): | ||
| tryfiles = ["index.html", "README.html"] | ||
| else: | ||
| tryfiles = ["index.html"] | ||
|
|
||
| if relpath == "404.html" or filename in tryfiles: |
There was a problem hiding this comment.
We should still keep tracking README.html files here. Otherwise, after a brown out is done, users will need to re-build their docs in order to have them serve a README file as index again.
There was a problem hiding this comment.
I don't understand your comment. We don't want README files being served as index after the brownout dates. Can you expand on this?
There was a problem hiding this comment.
We don't want to serve them on the brown out dates, but after one brown out is done (next day), we want to continue serving them. You are already doing that check at serve time, you don't need to remove the indexing of README files, that will make our serve code to not be aware of README files after a brown out is finished.
…mitos/readme-html-browndates
…cs/readthedocs.org into humitos/readme-html-browndates
Fully removal after deprecation and browndates. Reference: * #9993 * #11348 * https://about.readthedocs.com/blog/2024/05/readme-html-deprecated/
* Proxito: remove redirect for `README.html` files Fully removal after deprecation and browndates. Reference: * #9993 * #11348 * https://about.readthedocs.com/blog/2024/05/readme-html-deprecated/ * Simplify the logic for tryfiles on El Proxito * Add missing case * Remove README from the docstring
Related #9993