Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: convert About navigation to a dropdown #176

Closed
2 tasks done
agjohnson opened this issue Nov 29, 2022 · 5 comments · Fixed by #221
Closed
2 tasks done

Navigation: convert About navigation to a dropdown #176

agjohnson opened this issue Nov 29, 2022 · 5 comments · Fixed by #221
Assignees
Labels
Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Nov 29, 2022

From #174 and chat conversations, the current "About" navigation link should be something clearer, while retaining the flow of the top navigation menu. The best option is likely making "About" a dropdown, and most likely renaming the menu title to a more specific phrase like "Product".

  • Add dropdowns for desktop and mobile
  • Move about to a new page
@agjohnson agjohnson added the Improvement Minor improvement to code label Nov 29, 2022
@agjohnson
Copy link
Contributor Author

cc @ericholscher

This was the original plan for the menu item that was renamed to "Features". I'm still ±0 on "Product", but there is probably another word that fits well here too.

But I think even if we stick with "Product" the menu could be:

Product:
  - How Read the Docs works (this is the current "features" page, but was meant more as a overview page originally)
  - Features:
    - Building
    - Pull request previews
    - Authentication
    - etc
  - Supported tools:
    - Sphinx
    - Mkdocs
    - Unofficial tools

I think this helps solve focus of the existing "features" page and still gives us a reasonable menu item name for the top navigation. It also opens up the door to expanding navigation a great deal

@ericholscher
Copy link
Member

ericholscher commented Aug 10, 2023

Yea, I agree. This is a great place to focus on additional content 💯

Though I'd do s/Unnofficial/Custom or similar for marketing purposes :)

agjohnson added a commit that referenced this issue Aug 10, 2023
This is for:

- #176

But this is still just proof of concept level so far, the mobile menu is
a bit broken by this and the actual structure needs shaping up still.
@agjohnson
Copy link
Contributor Author

Started a draft PR at #221 but I didn't play around much with the content structure too much yet. It needs icons probably and the mobile menu is a bit broken by this too. Just putting it up for now as I end my day.

@ericholscher
Copy link
Member

Good example here: https://www.cerbos.dev/

@ericholscher ericholscher self-assigned this Feb 13, 2024
@agjohnson
Copy link
Contributor Author

Yeah, this is a fairly common pattern, here are some others:

To continue this work:

  • I would limit the number of items in the top nav to two items, maybe three though that is starting to overload the top navigation especially on tablet viewport sizes
  • There are some small visual tweaks needed with SUI, like adding a dropdown icon
  • The PR above breaks mobile navigation menu, as the dropdown menus aren't stacking nicely. It's not clear if an FUI submenu solves this or not.

agjohnson added a commit that referenced this issue Apr 3, 2024
This is for:

- #176

But this is still just proof of concept level so far, the mobile menu is
a bit broken by this and the actual structure needs shaping up still.
@agjohnson agjohnson assigned agjohnson and unassigned ericholscher Apr 3, 2024
@agjohnson agjohnson moved this from Planned to Needs review in 📍Roadmap Apr 3, 2024
agjohnson added a commit that referenced this issue Apr 10, 2024
* Add example navigation menu for dropdown product menu

This is for:

- #176

But this is still just proof of concept level so far, the mobile menu is
a bit broken by this and the actual structure needs shaping up still.

* Polish up navigation menus

This drops the concept of highlighting the navigation menu item on the
page slug, but adds two menus we can put content under to make content
discoverable.

This now works on desktop and mobile.

* Put pricing link in top level topnav too

I left the submenu option under product too, it looks nice there. The
size of the menu was reduced to match the beta dashboard, so elements
could fit.
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants