Run tests after builds are done, regardless of they failed or succeeded #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/pr-realm-js.yml
Outdated
| @@ -234,6 +234,7 @@ jobs: | |||
| integration-tests: | |||
| name: Integration tests (${{matrix.variant.target}}) for ${{ matrix.variant.environment }} on ${{ matrix.variant.os }} | |||
| needs: [bundle, build, ios-xcframework] | |||
| if: ${{ always() }} | |||
There was a problem hiding this comment.
I'm surprised that this does anything. Could you add a synthetic build failure (possibly in a pr on top of this, or just in a commit that you will rebase away) to see how it works?
There was a problem hiding this comment.
Sure. I just pushed a commit that will fail the windows runners
takameyer
force-pushed
the
test-workflow
branch
from
d8b5259
to
7f1d2b9
Compare
takameyer
force-pushed
the
test-workflow
branch
from
7f1d2b9
to
6fcc311
Compare
RedBeard0531
approved these changes
Apr 13, 2023
|
@RedBeard0531 I rebased and removed the commit that breaks builds. Seems the x64 build is breaking for other reasons, but one can see the tests still run! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
It would be good to know that which tests are passing, even if the builds aren't.
This closes # ???
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: