Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename local-mongodb to enable app replacements #5734

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Rename local-mongodb to enable app replacements #5734

merged 2 commits into from
Apr 17, 2023

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This fixes consistent app import failures on CI.

@cla-bot cla-bot bot added the cla: yes label Apr 14, 2023
@kraenhansen kraenhansen requested review from takameyer, elle-j and papafe and removed request for takameyer April 14, 2023 17:26
@kraenhansen
Copy link
Member Author

This seem to fix tests for node and RN iOS 👍

elle-j
elle-j approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 👍 Just left a question regarding the rename.

integration-tests/realm-apps/with-custom-function/secrets.json Outdated
"local-mongodb-uri": "mongodb://localhost:26000"
"mongodb_uri": "mongodb://localhost:26000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if the app importer might be relying on local-mongodb-uri given these other occurrences:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually .. Thinking more about it, it should probably not have been renamed.

@kraenhansen kraenhansen merged commit bb74833 into main Apr 17, 2023
@kraenhansen kraenhansen deleted the kh/fix-custom-auth-tests branch April 17, 2023 09:40
papafe added a commit that referenced this pull request Apr 17, 2023
@papafe
Merge branch 'main' into fp/core-logging
c670167 
* main:
  Update core to v13.9.1 (#5739)
  Implement `User.state` (#5712)
  Rename `local-mongodb` to enable app replacements (#5734)
  Update return type of 'assert.never'. (#5718)
  Run tests after builds are done, regardless of they failed or succeeded (#5729)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elle-j elle-j elle-j approved these changes

@papafe papafe Awaiting requested review from papafe

Assignees

@kraenhansen kraenhansen

Labels
cla: yes T-Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kraenhansen @elle-j