Autoformat all bash scripts #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbaird
force-pushed
the
autoformat-scripts
branch
3 times, most recently
from
25e24af
to
a9ee375
Compare
I want to use this in the next commit as a way to identify the bash scripts in the hacks directory. (Since they're not all ending with .sh we can't use the filename extention to identify them.)
simonbaird
force-pushed
the
autoformat-scripts
branch
from
a9ee375
to
8acb454
Compare
Add Makefile targets to install shfmt and run it. shfmt comes from https://github.com/mvdan/sh
The changes in this commit were made by running `make format` and checking in all the changes produced.
simonbaird
force-pushed
the
autoformat-scripts
branch
from
8acb454
to
c0aeae7
Compare
Prevent merging a PR if the bash hasn't been consistently formatted using `make format`.
simonbaird
force-pushed
the
autoformat-scripts
branch
from
c0aeae7
to
5d53590
Compare
zregvart
approved these changes
Nov 6, 2024
chmeliik
approved these changes
Nov 6, 2024
jduimovich
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
LGTM
The env-template.sh workaround can later be fixed by moving it out of the rhtap directory.
It was only there when this repo was used "live" ... As its should not be there we end up having other places where we deal with it specially.
It was also supposed to be "generated" in future, when we add metadata ot the scripts which can be used to define parameters (for tekton for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this will be popular or not, but see what you think about it.
I'd be happy to tweak the indenting rules (tabs, 2 spaces, whatever), so let me know if there's a preference.