Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoformat all bash scripts #42

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Autoformat all bash scripts #42

merged 5 commits into from
Nov 6, 2024

Commits on Nov 5, 2024

  1. Add bash shebang to scripts in hack directory 

    I want to use this in the next commit as a way to identify the bash
scripts in the hacks directory. (Since they're not all ending with
.sh we can't use the filename extention to identify them.)
    @simonbaird
    simonbaird committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4ee9ecb View commit details
    Browse the repository at this point in the history

  2. Prepare to autoformat all bash scripts 

    Add Makefile targets to install shfmt and run it.

shfmt comes from https://github.com/mvdan/sh
    @simonbaird
    simonbaird committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    4b2ec6d View commit details
    Browse the repository at this point in the history

  3. Apply autoformatting to all bash scripts 

    The changes in this commit were made by running `make format` and
checking in all the changes produced.
    @simonbaird
    simonbaird committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    31772f1 View commit details
    Browse the repository at this point in the history

  4. Add CI check to ensure scripts are autoformatted 

    Prevent merging a PR if the bash hasn't been consistently formatted
using `make format`.
    @simonbaird
    simonbaird committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5d53590 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Add make ci target to run all the checks

    @simonbaird
    simonbaird committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e7821ca View commit details
    Browse the repository at this point in the history