-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made sync lock consistent and added types to it #2137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2137 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 104 104
Lines 24364 24384 +20
=======================================
+ Hits 22524 22543 +19
- Misses 1840 1841 +1
Continue to review full report at Codecov.
|
Thanks @WisdomPill! It looks great to me! As you suggested - I would really appreciate if you add an async version as well |
nice! probably in the weekend I will be back at it :) |
sorry I did not finish working on the async version yet... I just started and got caught up by other things |
@WisdomPill I want to merge this PR so please open another PR when you done with the async version, and feel free to let me know if you need help with it |
👍 |
Fixes: #1348
Needed for: jazzband/django-redis#603
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?Description of change
Added blocking flag to client.lock and types to sync lock.
Some more nit picking inconsistency was fixed so that regardless on who the lock is used, all the options are the same.
If this is okay I will also add the same to the async version of the lock