Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added blocking parameter to lock #603

Closed

Conversation

WisdomPill
Copy link
Member

@WisdomPill WisdomPill commented Apr 18, 2022

Fixes: #596.

This cannot be done before changes in redis-py to standardize the signatures in lock, context manager and client.lock

pre-commit-ci bot and others added 2 commits May 10, 2022 09:38
updates:
- [github.com/asottile/pyupgrade: v2.32.0 → v2.32.1](asottile/pyupgrade@v2.32.0...v2.32.1)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
pre-commit-ci bot and others added 25 commits June 29, 2022 20:53
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.2.0 → v4.3.0](pre-commit/pre-commit-hooks@v4.2.0...v4.3.0)
- [github.com/asottile/pyupgrade: v2.32.1 → v2.34.0](asottile/pyupgrade@v2.32.1...v2.34.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
updates:
- [github.com/asottile/pyupgrade: v2.34.0 → v3.1.0](asottile/pyupgrade@v2.34.0...v3.1.0)
- [github.com/psf/black: 22.3.0 → 22.10.0](psf/black@22.3.0...22.10.0)
- [github.com/PyCQA/flake8: 4.0.1 → 5.0.4](PyCQA/flake8@4.0.1...5.0.4)
* jazzband#609, use pipeline for delete_pattern

* jazzband#609, add changelog description
…nfig

[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/asottile/pyupgrade: v3.1.0 → v3.2.0](asottile/pyupgrade@v3.1.0...v3.2.0)
mypy: ignore `default_timeout` can be `None`
Add Django 4.1 to test matrix and classifiers
…nfig

[pre-commit.ci] pre-commit autoupdate
Log traceback if exceptions are ignored
Saurav Sharma and others added 28 commits February 16, 2024 15:17
Fix:Expire method fails when using DEFAULT_TIMEOUT
…nfig

[pre-commit.ci] pre-commit autoupdate
…ngo50

Dropped django4.1 and added django 5.0
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.2.1 → v0.2.2](astral-sh/ruff-pre-commit@v0.2.1...v0.2.2)
- [github.com/psf/black: 24.1.1 → 24.2.0](psf/black@24.1.1...24.2.0)
…nfig

[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
- [github.com/astral-sh/ruff-pre-commit: v0.2.2 → v0.4.8](astral-sh/ruff-pre-commit@v0.2.2...v0.4.8)
- [github.com/psf/black: 24.2.0 → 24.4.2](psf/black@24.2.0...24.4.2)
…nto pre-commit-ci-update-config

# Conflicts:
#	.pre-commit-config.yaml
…nfig

[pre-commit.ci] pre-commit autoupdate
Add support for the set functions from issue jazzband#597
@WisdomPill WisdomPill closed this Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 89.80583% with 42 lines in your changes missing coverage. Please review.

Project coverage is 90.3%. Comparing base (4e7f2d4) to head (2c10137).
Report is 209 commits behind head on master.

Files with missing lines Patch % Lines
django_redis/client/default.py 91.4% 17 Missing ⚠️
django_redis/client/sharded.py 87.7% 9 Missing ⚠️
django_redis/pool.py 60.0% 6 Missing ⚠️
django_redis/__init__.py 25.0% 3 Missing ⚠️
django_redis/compressors/lzma.py 0.0% 3 Missing ⚠️
django_redis/client/herd.py 81.9% 2 Missing ⚠️
django_redis/client/sentinel.py 33.4% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #603      +/-   ##
=========================================
+ Coverage    57.8%   90.3%   +32.6%     
=========================================
  Files          39      22      -17     
  Lines        2497    1346    -1151     
  Branches       73       0      -73     
=========================================
- Hits         1441    1215     -226     
+ Misses       1041     131     -910     
+ Partials       15       0      -15     
Flag Coverage Δ
mypy ?
tests 90.3% <89.9%> (+7.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default client does not pass blocking kwarg through lock method
10 participants