Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-react): fix submitter serialization (alt approach) #4475

Closed
wants to merge 1 commit into from
Closed

fix(remix-react): fix submitter serialization (alt approach) #4475

wants to merge 1 commit into from

Commits on Nov 5, 2022

  1. fix(remix-react): fix submitter serialization 

    Bring `<Form>` submissions in line with the spec with respect to how and where
form submitters are serialized within the data set. We accomplish this by
constructing the form data set ourselves according to the spec.

Problems fixed:
1. Serialize submitters in tree order (i.e. where they appear in the DOM)
2. Serialize Image Button submitter correctly (i.e. separate x and y coordinate
   entries, rather than a single empty entry)
3. Stop sending multiple entries in older WebKit

References: remix-run#4342
Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set
    @jenseng
    jenseng committed Nov 5, 2022
    Configuration menu
    Copy the full SHA
    4dbdc64 View commit details
    Browse the repository at this point in the history