fix(remix-react): fix submitter serialization (alt approach) #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4dbdc64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
jenseng
force-pushed
the
fix-form-submitters-alt
branch
from
7b72226
to
35f7aac
Compare
|
This feels a tad less hacky than the other approach, but it's a lot more code to maintain, and as the spec evolves we'll have to keep tweaking the implementation, increasing the likelihood of bugs/etc. |
jenseng
commented
Nov 1, 2022
jenseng
commented
Nov 1, 2022
Bring `<Form>` submissions in line with the spec with respect to how and where form submitters are serialized within the data set. We accomplish this by constructing the form data set ourselves according to the spec. Problems fixed: 1. Serialize submitters in tree order (i.e. where they appear in the DOM) 2. Serialize Image Button submitter correctly (i.e. separate x and y coordinate entries, rather than a single empty entry) 3. Stop sending multiple entries in older WebKit References: remix-run#4342 Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set
jenseng
force-pushed
the
fix-form-submitters-alt
branch
from
35f7aac
to
4dbdc64
Compare
|
Closing in favor of remix-run/react-router#9866, since the code has moved there |
jenseng
added a commit
to jenseng/react-router
that referenced
this pull request
Jan 10, 2023
This is the RR port of remix-run/remix#4475 Bring `<Form>` submissions in line with the spec with respect to how and where form submitters are serialized within the data set. We accomplish this by constructing the form data set ourselves according to the spec. Problems fixed: 1. Serialize submitters in tree order (i.e. where they appear in the DOM) 2. Serialize Image Button submitter correctly (i.e. separate x and y coordinate entries, rather than a single empty entry) 3. Stop sending multiple entries in older WebKit References: remix-run/remix#4342 Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I have two proposals on how we can fix the submitter serialization bugs. The other approach is here.
Bring
<Form>submissions in line with the spec with respect to how and where form submitters are serialized within the data set.Alt solution: We accomplish this by constructing the form data set ourselves according to the spec.
Problems fixed:
References: #4342
Spec: https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set