Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datasource): support range constraints filtering #20842

Merged
merged 14 commits into from
Mar 15, 2023
Merged

feat(datasource): support range constraints filtering #20842

merged 14 commits into from
Mar 15, 2023

Conversation

Lctrs
Copy link
Contributor

@Lctrs Lctrs commented Mar 10, 2023 •
edited
Loading

Changes

  • Adds an optional method subset to VersioningApi interface that returns true if first argument is a subset of second argument, false otherwise
  • Adds implementations for it in npm, composer, and python versioning
  • Uses it in releases filtering in strict constraints mode with fallback to matching

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@Lctrs Lctrs changed the title Feat/18715 php filter releases feat(datasource): support range constraints filtering Mar 10, 2023
@Lctrs Lctrs mentioned this pull request Mar 10, 2023
Closed
6 tasks
@rarkins rarkins requested a review from viceice March 10, 2023 10:23
rarkins
rarkins requested changes Mar 11, 2023
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs coverage update

@rarkins
Copy link
Collaborator

rarkins commented Mar 12, 2023

Missing coverage:

image

viceice
viceice previously approved these changes Mar 12, 2023
View reviewed changes
@viceice viceice requested a review from rarkins March 12, 2023 19:21
@rarkins
Copy link
Collaborator

rarkins commented Mar 13, 2023

@Lctrs have you done any recent sanity test on a real repo?

@Lctrs
Copy link
Contributor Author

Lctrs commented Mar 13, 2023

@rarkins just did it in https://github.com/Lctrs/playground/pull/2. Still works well.

@rarkins rarkins requested a review from viceice March 14, 2023 05:24
rarkins
rarkins requested changes Mar 14, 2023
View reviewed changes
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
@rarkins rarkins added this pull request to the merge queue Mar 15, 2023
Merged via the queue into renovatebot:main with commit 2e25de1 Mar 15, 2023
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Lctrs Lctrs deleted the feat/18715-php-filter-releases branch March 15, 2023 10:48
@nikolaik nikolaik mentioned this pull request Mar 23, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP lookup constraints Support range/range constraints filtering
4 participants
@Lctrs @rarkins @renovate-release @viceice