feat(datasource): support range constraints filtering #20217

Lctrs · 2023-02-04T01:20:56Z

Changes

Adds an optional method subset to VersioningApi interface that returns true if first argument is a subset of second argument, false otherwise
Adds implementations for it in npm and composer versioning
Uses it in releases filtering in strict constraints mode with fallback to matching
Extracts release's constraints from packagist datasource

Context

Closes Support range/range constraints filtering #8476
Closes PHP lookup constraints #18715
Closes feat(composer): filter releases using php constraint #19851

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

rarkins · 2023-02-04T05:39:24Z

I don't see the extractedConstraints part.

Blocked by #19979 (i.e. waiting for v35, or could be combined with it)

lib/modules/datasource/index.ts

lib/modules/versioning/composer/index.ts

lib/modules/versioning/types.ts

lib/modules/versioning/composer/index.ts

lib/modules/versioning/pep440/index.ts

lib/modules/versioning/types.ts

lib/modules/versioning/python/index.ts

lib/modules/versioning/types.ts

rarkins · 2023-02-17T06:09:01Z

@Lctrs this PR is looking good. Do you have any public repos you've been testing against?

Lctrs · 2023-02-17T09:40:22Z

@rarkins no. I trusted the test suite. How can I do that ?

rarkins · 2023-02-17T09:41:33Z

@Lctrs just have some public repos on github.com which achieve what you're after. For example it could be a Node.js upgrade where the new version requires Node 18 but the project supports 16 and 18, or something similar with python or PHP versions.

Lctrs · 2023-02-18T14:32:39Z

So, I've been able to make it work on a composer project with the last commit.

On https://github.com/Lctrs/php-library-skeleton which runs against the official renovate app, renovate opens this update PR which contains an invalid update for maglnet/composer-require-checker.

On a forked repo, I've got this PR https://github.com/Lctrs/playground/pull/2 which does not contain the invalid update.

docs/usage/self-hosted-configuration.md

lib/modules/versioning/composer/index.ts

Changes `rangeStrategy` default value from `'replace'` to `'auto'`. Changes `auto` behavior so that `update-lockfile` is preferred if the manager supports the `updateLockedDependency()` function. Closes #19800 BREAKING CHANGE: Renovate will now default to updating locked dependency versions. To revert to previous behavior, configure rangeStrategy=replace.

…9958) Sets new defaults: - `prConcurrentLimit`: 10 (instead of 0) - `prHourlyLimit`: 2 (instead of 0) Closes #19800 BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.

Set default GOPROXY value to match `go`'s own default. Closes #20040 BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.

Checks file cache for expired items at the end of a run. Non-breaking change but it may result in some long cleanup jobs for any bots which have been left to populate their package cache for a long time. Closes #13732

Co-authored-by: HonkingGoose <[email protected]>

…0474)

…git tag, and preserve existing digest semantics as separate datasource (#20178) Co-authored-by: RahulGautamSingh <[email protected]> Co-authored-by: Rhys Arkins <[email protected]> Co-authored-by: Michael Kriese <[email protected]> Co-authored-by: HonkingGoose <[email protected]>

Closes #18715 Closes #8476

rarkins · 2023-02-23T09:39:19Z

This feature is not itself breaking, but it relies on a breaking change in v35.0.0. Should we include it in v35.0.0 or merge it as v35.1.0 after?

Lctrs · 2023-02-23T09:51:41Z

If I have any saying in this decision, I would say ship it ASAP as it's ready.

rarkins · 2023-02-23T10:18:50Z

It would only be a difference of a few hours at most, once v35 is released

Lctrs · 2023-02-23T19:58:35Z

@rarkins It's up to you :)

Lctrs · 2023-03-10T09:55:56Z

@rarkins Should I reopen it against main branch ?

rarkins · 2023-03-10T09:57:53Z

I didn't close it intentionally, sorry. Seems it was closed as a result of v35 getting merged and deleted. Please restore it and retarget towards main and we'll try to get it merged today!

Lctrs · 2023-03-10T10:10:17Z

Can't do it by myself. I can't reopen the PR and retarget the branch. But I've rebased my branch on top of main on my fork.

rarkins · 2023-03-10T10:15:47Z

Can you open a new PR?

Lctrs · 2023-03-10T10:22:09Z

Done #20842

rarkins reviewed Feb 4, 2023

View reviewed changes

lib/modules/datasource/index.ts Outdated Show resolved Hide resolved

Lctrs changed the base branch from main to v35 February 4, 2023 19:32

Lctrs changed the title ~~feat(composer): filter releases using php constraint~~ feat(datasource): support range constraints filtering Feb 4, 2023

rarkins reviewed Feb 5, 2023

View reviewed changes

lib/modules/versioning/composer/index.ts Outdated Show resolved Hide resolved

viceice reviewed Feb 5, 2023

View reviewed changes

lib/modules/versioning/types.ts Outdated Show resolved Hide resolved

viceice reviewed Feb 6, 2023

View reviewed changes

lib/modules/versioning/composer/index.ts Outdated Show resolved Hide resolved

rarkins force-pushed the v35 branch from a5577c3 to 11c0960 Compare February 10, 2023 14:28

Lctrs marked this pull request as ready for review February 16, 2023 09:35

viceice requested changes Feb 16, 2023

View reviewed changes

lib/modules/versioning/pep440/index.ts Outdated Show resolved Hide resolved

lib/modules/versioning/types.ts Outdated Show resolved Hide resolved

lib/modules/versioning/python/index.ts Outdated Show resolved Hide resolved

viceice reviewed Feb 16, 2023

View reviewed changes

lib/modules/versioning/types.ts Outdated Show resolved Hide resolved

viceice approved these changes Feb 16, 2023

View reviewed changes

viceice requested a review from rarkins February 16, 2023 18:45

rarkins force-pushed the v35 branch from a0a091b to 903ad6a Compare February 17, 2023 07:16

rarkins force-pushed the v35 branch from 903ad6a to 6e8c6c6 Compare February 20, 2023 14:23

viceice reviewed Feb 21, 2023

View reviewed changes

docs/usage/self-hosted-configuration.md Show resolved Hide resolved

viceice reviewed Feb 21, 2023

View reviewed changes

lib/modules/versioning/composer/index.ts Outdated Show resolved Hide resolved

Lctrs mentioned this pull request Feb 21, 2023

fix(versioning/composer): support range versions normalization #20558

Merged

6 tasks

RahulGautamSingh and others added 8 commits February 23, 2023 06:30

feat(config)!: add new option constraintsFiltering (#19992)

a42fe41

feat(cache): default cacheHardTtlMinutes to 24 hours (#20079)

0c681f7

feat(go)!: default GOPROXY (#20081)

1b58035

Set default GOPROXY value to match `go`'s own default. Closes #20040 BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.

fix(regex): don’t escape forward slash in fileMatch (#19314)

885ce79

feat(cache): file cache cleanup (#20061)

88cb161

Checks file cache for expired items at the end of a run. Non-breaking change but it may result in some long cleanup jobs for any bots which have been left to populate their package cache for a long time. Closes #13732

feat(config): default dockerImagePrefix to containerbase (#20150)

81c0531

Co-authored-by: HonkingGoose <[email protected]>

rarkins and others added 3 commits February 23, 2023 06:31

fix(versioning)!: bump short ranges to version (#20494)

9fbe4a2

refactor!: use packageName and not depName for datasource lookups (#2…

0592942

…0474)

rarkins force-pushed the v35 branch from a1b2e5d to fd279f0 Compare February 23, 2023 05:55

Lctrs added 4 commits February 23, 2023 10:37

feat(datasource): support range constraints filtering

27f10b2

Closes #18715 Closes #8476

add tests, tsdoc, subset support for python & simplify subset calls

425766a

cs, tests, review fixes

83f9ebb

rename subset params

47aced9

viceice approved these changes Feb 23, 2023

View reviewed changes

rarkins force-pushed the v35 branch 3 times, most recently from 491f0eb to a6bbf93 Compare March 4, 2023 05:30

rarkins force-pushed the v35 branch 5 times, most recently from 181a4d7 to a4ab452 Compare March 10, 2023 08:34

rarkins deleted the branch renovatebot:v35 March 10, 2023 09:53

rarkins closed this Mar 10, 2023

Lctrs mentioned this pull request Mar 10, 2023

feat(datasource): support range constraints filtering #20842

Merged

6 tasks

github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(datasource): support range constraints filtering #20217

feat(datasource): support range constraints filtering #20217

Lctrs commented Feb 4, 2023 •

edited by viceice

Loading

rarkins commented Feb 4, 2023

rarkins commented Feb 17, 2023

Lctrs commented Feb 17, 2023

rarkins commented Feb 17, 2023

Lctrs commented Feb 18, 2023

rarkins commented Feb 23, 2023

Lctrs commented Feb 23, 2023

rarkins commented Feb 23, 2023

Lctrs commented Feb 23, 2023

Lctrs commented Mar 10, 2023

rarkins commented Mar 10, 2023

Lctrs commented Mar 10, 2023

rarkins commented Mar 10, 2023

Lctrs commented Mar 10, 2023

feat(datasource): support range constraints filtering #20217

feat(datasource): support range constraints filtering #20217

Conversation

Lctrs commented Feb 4, 2023 • edited by viceice Loading

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

rarkins commented Feb 4, 2023

rarkins commented Feb 17, 2023

Lctrs commented Feb 17, 2023

rarkins commented Feb 17, 2023

Lctrs commented Feb 18, 2023

rarkins commented Feb 23, 2023

Lctrs commented Feb 23, 2023

rarkins commented Feb 23, 2023

Lctrs commented Feb 23, 2023

Lctrs commented Mar 10, 2023

rarkins commented Mar 10, 2023

Lctrs commented Mar 10, 2023

rarkins commented Mar 10, 2023

Lctrs commented Mar 10, 2023

Lctrs commented Feb 4, 2023 •

edited by viceice

Loading