Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bitbucket-pipelines): authenticated registries #21096

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Mar 23, 2023

Changes

Add documentation for

  • authenticated registry support
  • migrating from unauthenticated to authenticated registry formats

Context

Publishing examples from these two sources

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@setchy setchy changed the title Docs/bitbucket pipelines authenticated registries docs(bitbucket-pipelines): authenticated registries Mar 23, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should extend manager support instead

@setchy
Copy link
Collaborator Author

setchy commented Mar 23, 2023

we should extend manager support instead

Agree, and there is an open issue to track that.

But until then, why not improve the docs? Can easily remove the regexs manager examples if and when the bitbucket-pipelines manager parses the yml, which would only improve authenticated image handling, I cannot see it supporting moving from unauthenticated to authenticated image structures

@setchy
Copy link
Collaborator Author

setchy commented Mar 23, 2023

we should extend manager support instead

#21107 - updated bitbucket-pipelines manager extract logic.

Note: I have not attempted to parse the yaml as suggested by @viceice here - so ordering is important (but also incredibly common).

@setchy
Copy link
Collaborator Author

setchy commented Mar 23, 2023

Moving to draft until feedback re: #21107

@setchy setchy marked this pull request as draft March 23, 2023 12:07

Bitbucket Pipelines supports using an authenticated Docker registry, including self-hosted private registries, Docker Hub, Amazon ECR and Google GCR.

More details can be found on the Atlassian [Bitbucket Pipeline documentation](https://support.atlassian.com/bitbucket-cloud/docs/use-docker-images-as-build-environments) site
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
More details can be found on the Atlassian [Bitbucket Pipeline documentation](https://support.atlassian.com/bitbucket-cloud/docs/use-docker-images-as-build-environments) site
More details can be found on the Atlassian [Bitbucket Pipeline documentation](https://support.atlassian.com/bitbucket-cloud/docs/use-docker-images-as-build-environments) site.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HonkingGoose

I'll be updating this PR one @viceice can land #21102

lib/modules/manager/bitbucket-pipelines/readme.md Outdated Show resolved Hide resolved
lib/modules/manager/bitbucket-pipelines/readme.md Outdated Show resolved Hide resolved
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 35.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants