Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use yaml instead of js-yaml for parsing YAML files #31336

Merged
merged 2 commits into from
Sep 16, 2024
Merged

refactor: use yaml instead of js-yaml for parsing YAML files #31336

merged 2 commits into from
Sep 16, 2024

Conversation

secustor
Copy link
Collaborator

Changes

Replaces js-yaml with yaml as the former has not received updates in the last 3 years.

Also this library supports adding tag handling, which would allow us to natevily handle !reference tags in GitlabCI

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor requested a review from viceice September 11, 2024 14:14
viceice
viceice reviewed Sep 11, 2024
View reviewed changes
lib/modules/datasource/bitrise/schema.ts Show resolved Hide resolved
lib/util/yaml.ts Show resolved Hide resolved
lib/util/yaml.ts Show resolved Hide resolved
@websi websi mentioned this pull request Sep 13, 2024
Merged
6 tasks
@rarkins rarkins requested a review from viceice September 16, 2024 05:08
viceice
viceice previously approved these changes Sep 16, 2024
View reviewed changes
@secustor secustor enabled auto-merge September 16, 2024 17:40
@secustor secustor requested a review from viceice September 16, 2024 17:47
@secustor secustor added this pull request to the merge queue Sep 16, 2024
Merged via the queue into renovatebot:main with commit d74ba70 Sep 16, 2024
38 checks passed
@secustor secustor deleted the refactor/use-yaml branch September 16, 2024 18:13
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.84.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

websi added a commit to dkd/renovate that referenced this pull request Oct 4, 2024
@websi
refactor(manager/gitlabci): remove method "replaceReferenceTags"
4e4d181 
Since renovatebot#31336 the replacement of the reference tag from GitLab is not needed anymore
@websi websi mentioned this pull request Oct 4, 2024
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@secustor @renovate-release @viceice