Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest egui master #6683

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Update to latest egui master #6683

merged 6 commits into from
Jul 1, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jun 30, 2024 •
edited by github-actions bot
Loading

What

With this update, we now format numbers in DragValues using re_format, i.e. with thousands separators. This makes large editable components easier to read, and makes our UI more consistent.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface dependencies concerning crates, pip packages etc exclude from changelog PRs with this won't show up in CHANGELOG.md egui Requires egui/eframe work labels Jun 30, 2024
@emilk emilk force-pushed the emilk/update-egui branch from 7874c43 to 3999a31 Compare June 30, 2024 16:13
@Wumpf Wumpf self-requested a review July 1, 2024 08:25
Wumpf
Wumpf approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

crates/re_space_view_time_series/src/space_view_class.rs Show resolved Hide resolved
crates/re_ui/src/lib.rs Show resolved Hide resolved
crates/re_ui/src/lib.rs Outdated Show resolved Hide resolved
@Wumpf
Copy link
Member

Wumpf commented Jul 1, 2024 •
edited
Loading

Actually I'm a bit torn on the looks for decimal separation after the dot 🤔. Still useful but a less common sight
image

@emilk
Copy link
Member Author

emilk commented Jul 1, 2024

Actually I'm a bit torn on the looks for decimal separation after the dot 🤔. Still useful but a less common sight

Yeah, that particular case doesn't look great. Maybe we should only add thousands separators after the dot if there is more than 5 or so digits after the dot. Still, this is a pre-existing problem in re_format. PRs welcome.

@emilk emilk merged commit edb6ede into main Jul 1, 2024
34 checks passed
@emilk emilk deleted the emilk/update-egui branch July 1, 2024 08:59
@emilk
Copy link
Member Author

emilk commented Jul 1, 2024

I can make a quick fix for re_format. Jeremy pointed out the same thing a few months back

@emilk emilk mentioned this pull request Jul 1, 2024
Merged
5 tasks
emilk added a commit that referenced this pull request Jul 1, 2024
@emilk
Don't show thousands separators for decimals until there are at least…
888e3cc 
… 6 (#6689)

### What
See #6683 (comment)
Also pointed out by Jeremy a long time ago.


![image](https://github.com/rerun-io/rerun/assets/1148717/b19a747f-8053-45af-b1c6-eeda45a6e065)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6689?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6689?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6689)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc egui Requires egui/eframe work exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending a blueprint withan empty barchart crashes the viewer
2 participants
@emilk @Wumpf