Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show thousands separators for decimals until there are at least 6 #6689

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Don't show thousands separators for decimals until there are at least 6 #6689

merged 1 commit into from
Jul 1, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jul 1, 2024 •
edited
Loading

What

See #6683 (comment)
Also pointed out by Jeremy a long time ago.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jul 1, 2024
@emilk emilk merged commit 888e3cc into main Jul 1, 2024
36 of 37 checks passed
@emilk emilk deleted the emilk/decimal-thousands-separators branch July 1, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @teh-cmc