Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC spec update: define recording schema protobuf types and expose the schema via new endpoint #8651

Merged
merged 8 commits into from
Jan 14, 2025

Conversation

zehiko
Copy link
Contributor

@zehiko zehiko commented Jan 10, 2025

What

Define column descriptors in the protobuf spec and the relevant type conversions. Add new endpoint for fetching the schema that returns a list of column descriptors.

Also updated the example script to use the next endpoint and print the schema.

@zehiko zehiko added exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API labels Jan 10, 2025
@zehiko zehiko self-assigned this Jan 10, 2025
Copy link

github-actions bot commented Jan 10, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
76d92b9 https://rerun.io/viewer/pr/8651 +nightly +main

Note: This comment is updated whenever you push a commit.

@zehiko zehiko changed the title Draft: gRPC spec update: define recording schema and expose the schema Draft: gRPC spec update: define recording schema protobuf types and expose the schema via new endpoint Jan 10, 2025
Base automatically changed from zehiko/projection-filtering to main January 13, 2025 08:17
@zehiko zehiko marked this pull request as ready for review January 13, 2025 14:17
@zehiko zehiko changed the title Draft: gRPC spec update: define recording schema protobuf types and expose the schema via new endpoint gRPC spec update: define recording schema protobuf types and expose the schema via new endpoint Jan 13, 2025
@zehiko zehiko merged commit ecdc4d7 into main Jan 14, 2025
34 checks passed
@zehiko zehiko deleted the zehiko/get-schema branch January 14, 2025 15:16
emilk added a commit that referenced this pull request Jan 14, 2025
* Reverts #8658
* Why? Because it conflicted with
#8651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md remote-store remote store gRPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants