Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially revert TimeColumnDescriptor refactor #8685

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Partially revert TimeColumnDescriptor refactor #8685

merged 3 commits into from
Jan 14, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 14, 2025

@emilk emilk changed the title Revert "Refactor TimeColumnDescriptor" Partially revert TimeColumnDescriptor refactor Jan 14, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 86bc035 https://rerun.io/viewer/pr/8685 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk added 🏹 arrow concerning arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Jan 14, 2025
@emilk emilk marked this pull request as ready for review January 14, 2025 15:42
@emilk emilk merged commit d4f99a1 into main Jan 14, 2025
30 of 31 checks passed
@emilk emilk deleted the revert-8658-emilk/remove-timeline-descr-datatype branch January 14, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zehiko zehiko zehiko approved these changes

Assignees
No one assigned
Labels
🏹 arrow concerning arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @zehiko