Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ArrowMsg to using arrow::RecordBatch #8669

Merged
merged 32 commits into from
Jan 14, 2025
Merged

Port ArrowMsg to using arrow::RecordBatch #8669

merged 32 commits into from
Jan 14, 2025

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 13, 2025

Related

Details

I'd like to replace our TransportChunk with arrow's RecordBatch.

This is a good step in that direction.

@emilk emilk added 🏹 arrow concerning arrow 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 13, 2025
@emilk
Copy link
Member Author

emilk commented Jan 13, 2025

@rerun-bot full-check

Copy link

Copy link

github-actions bot commented Jan 13, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
6836bd2 https://rerun.io/viewer/pr/8669 +nightly +main

Note: This comment is updated whenever you push a commit.

@rerun-io rerun-io deleted a comment from github-actions bot Jan 13, 2025
@emilk
Copy link
Member Author

emilk commented Jan 13, 2025

@rerun-bot full-check

@emilk emilk marked this pull request as ready for review January 13, 2025 20:05
Copy link

Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks like we're getting precariously close to not needing TransportChunk at all anymore!

Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Jeremy Leibs <[email protected]>
@emilk
Copy link
Member Author

emilk commented Jan 14, 2025

@rerun-bot full-check

Copy link

@rerun-io rerun-io deleted a comment from github-actions bot Jan 14, 2025
@emilk
Copy link
Member Author

emilk commented Jan 14, 2025

@rerun-bot full-check

Copy link

@emilk
Copy link
Member Author

emilk commented Jan 14, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12767918733

@emilk emilk merged commit 3a8c22f into main Jan 14, 2025
65 checks passed
@emilk emilk deleted the emilk/arrow-msg branch January 14, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏹 arrow concerning arrow exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants