Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine if it is possible to publish risc0-aggregation with set builder image ID and ELF #353

Open
nategraf opened this issue Dec 5, 2024 · 1 comment
Open

Determine if it is possible to publish risc0-aggregation with set builder image ID and ELF #353

nategraf opened this issue Dec 5, 2024 · 1 comment
Labels
build

Comments

@nategraf
Copy link
Contributor

nategraf commented Dec 5, 2024

No description provided.

@linear Linear
Copy link

linear bot commented Dec 5, 2024

WEB3-253 Determine if it is possible to publish risc0-aggregation with set builder image ID and ELF

@nategraf nategraf added the build label Dec 5, 2024
@nategraf nategraf mentioned this issue Dec 5, 2024
Merged
nategraf added a commit that referenced this issue Dec 5, 2024
@nategraf
WEB3-254: Remove dependencies of set-builder-guest to allow publishin…
f9e64e4 
…g to crates.io (#354)

This PR resolves issues with publishing `risc0-aggregation` stemming
from dependency on the `set-builder` guest through Cargo.
It does so by removing usage of that guest, which is in the form of all
code dependending on `SET_BUILDER_ID` or `SET_BUILDER_ELF`.
In practice, these values are difficult to use anyway, because they need
to align with an on-chain verifier. Unless reproducible builds are
always used, these values will flucuate.
There is an open issue on how to better manage these values.

Related #353
nategraf added a commit that referenced this issue Dec 5, 2024
@nategraf
WEB3-254: Remove dependencies of set-builder-guest to allow publishin…
b00fc13 
…g to crates.io (#354)

This PR resolves issues with publishing `risc0-aggregation` stemming
from dependency on the `set-builder` guest through Cargo.
It does so by removing usage of that guest, which is in the form of all
code dependending on `SET_BUILDER_ID` or `SET_BUILDER_ELF`.
In practice, these values are difficult to use anyway, because they need
to align with an on-chain verifier. Unless reproducible builds are
always used, these values will flucuate.
There is an open issue on how to better manage these values.

Related #353
@nategraf nategraf mentioned this issue Dec 5, 2024
Merged
capossele pushed a commit that referenced this issue Dec 6, 2024
@nategraf
Chery-pick: Remove dependencies of set-builder-guest to allow publish…
19a0da0 
…ing to crates.io (#354) (#357)

This PR resolves issues with publishing `risc0-aggregation` stemming
from dependency on the `set-builder` guest through Cargo.
It does so by removing usage of that guest, which is in the form of all
code dependending on `SET_BUILDER_ID` or `SET_BUILDER_ELF`.
In practice, these values are difficult to use anyway, because they need
to align with an on-chain verifier. Unless reproducible builds are
always used, these values will flucuate.
There is an open issue on how to better manage these values.

Related #353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nategraf