WEB3-254: Remove dependencies of set-builder-guest to allow publishing to crates.io #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Wollac
approved these changes
Dec 5, 2024
nategraf
added a commit
that referenced
this pull request
Dec 5, 2024
…g to crates.io (#354) This PR resolves issues with publishing `risc0-aggregation` stemming from dependency on the `set-builder` guest through Cargo. It does so by removing usage of that guest, which is in the form of all code dependending on `SET_BUILDER_ID` or `SET_BUILDER_ELF`. In practice, these values are difficult to use anyway, because they need to align with an on-chain verifier. Unless reproducible builds are always used, these values will flucuate. There is an open issue on how to better manage these values. Related #353
capossele
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ing to crates.io (#354) (#357) This PR resolves issues with publishing `risc0-aggregation` stemming from dependency on the `set-builder` guest through Cargo. It does so by removing usage of that guest, which is in the form of all code dependending on `SET_BUILDER_ID` or `SET_BUILDER_ELF`. In practice, these values are difficult to use anyway, because they need to align with an on-chain verifier. Unless reproducible builds are always used, these values will flucuate. There is an open issue on how to better manage these values. Related #353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issues with publishing
risc0-aggregationstemming from dependency on theset-builderguest through Cargo.It does so by removing usage of that guest, which is in the form of all code dependending on
SET_BUILDER_IDorSET_BUILDER_ELF.In practice, these values are difficult to use anyway, because they need to align with an on-chain verifier. Unless reproducible builds are always used, these values will flucuate.
There is an open issue on how to better manage these values.
Related #353