metrics(hummock): add hummock version size metric (#2348)

risingwavelabs · May 6, 2022 · 484c941 · 484c941
1 parent 5628dc7
commit 484c941
Show file tree

Hide file tree

Showing 3 changed files with 118 additions and 14 deletions.
diff --git a/grafana/risingwave-dashboard.json b/grafana/risingwave-dashboard.json
@@ -59,7 +59,7 @@
 	"fiscalYearStartMonth": 0,
 	"graphTooltip": 0,
 	"id": 2,
-	"iteration": 1650019185521,
+	"iteration": 1651822117209,
 	"links": [],
 	"liveNow": true,
 	"panels": [
@@ -518,8 +518,8 @@
 						"mode": "palette-classic"
 					},
 					"custom": {
-						"axisLabel": "",
-						"axisPlacement": "auto",
+						"axisLabel": "KB",
+						"axisPlacement": "left",
 						"barAlignment": 0,
 						"drawStyle": "line",
 						"fillOpacity": 0,
@@ -568,7 +568,7 @@
 				"x": 12,
 				"y": 18
 			},
-			"id": 168,
+			"id": 180,
 			"options": {
 				"legend": {
 					"calcs": [],
@@ -586,13 +586,22 @@
 						"uid": "PEDE6B306CC9C0CD0"
 					},
 					"exemplar": true,
-					"expr": "storage_level_compact_read_curr",
+					"expr": "version_size / 1024.0",
+					"instant": false,
 					"interval": "",
-					"legendFormat": "",
+					"legendFormat": "version size",
 					"refId": "A"
+				},
+				{
+					"datasource": {
+						"type": "prometheus",
+						"uid": "PEDE6B306CC9C0CD0"
+					},
+					"hide": false,
+					"refId": "B"
 				}
 			],
-			"title": "GBs read from current level",
+			"title": "Hummock Version Size",
 			"type": "timeseries"
 		},
 		{
@@ -738,7 +747,7 @@
 				"x": 12,
 				"y": 26
 			},
-			"id": 172,
+			"id": 168,
 			"options": {
 				"legend": {
 					"calcs": [],
@@ -756,13 +765,13 @@
 						"uid": "PEDE6B306CC9C0CD0"
 					},
 					"exemplar": true,
-					"expr": "storage_level_compact_write",
+					"expr": "storage_level_compact_read_curr",
 					"interval": "",
 					"legendFormat": "",
 					"refId": "A"
 				}
 			],
-			"title": "GBs written to next level",
+			"title": "GBs read from current level",
 			"type": "timeseries"
 		},
 		{
@@ -908,7 +917,7 @@
 				"x": 12,
 				"y": 34
 			},
-			"id": 176,
+			"id": 172,
 			"options": {
 				"legend": {
 					"calcs": [],
@@ -926,13 +935,13 @@
 						"uid": "PEDE6B306CC9C0CD0"
 					},
 					"exemplar": true,
-					"expr": "storage_level_compact_read_sstn_next",
+					"expr": "storage_level_compact_write",
 					"interval": "",
 					"legendFormat": "",
 					"refId": "A"
 				}
 			],
-			"title": "count of sst read from next level",
+			"title": "GBs written to next level",
 			"type": "timeseries"
 		},
 		{
@@ -1020,6 +1029,91 @@
 			"title": "count of sst written to next level",
 			"type": "timeseries"
 		},
+		{
+			"description": "",
+			"fieldConfig": {
+				"defaults": {
+					"color": {
+						"mode": "palette-classic"
+					},
+					"custom": {
+						"axisLabel": "",
+						"axisPlacement": "auto",
+						"barAlignment": 0,
+						"drawStyle": "line",
+						"fillOpacity": 0,
+						"gradientMode": "none",
+						"hideFrom": {
+							"legend": false,
+							"tooltip": false,
+							"viz": false
+						},
+						"lineInterpolation": "linear",
+						"lineWidth": 1,
+						"pointSize": 5,
+						"scaleDistribution": {
+							"type": "linear"
+						},
+						"showPoints": "auto",
+						"spanNulls": false,
+						"stacking": {
+							"group": "A",
+							"mode": "none"
+						},
+						"thresholdsStyle": {
+							"mode": "off"
+						}
+					},
+					"mappings": [],
+					"thresholds": {
+						"mode": "absolute",
+						"steps": [
+							{
+								"color": "green",
+								"value": null
+							},
+							{
+								"color": "red",
+								"value": 80
+							}
+						]
+					}
+				},
+				"overrides": []
+			},
+			"gridPos": {
+				"h": 8,
+				"w": 12,
+				"x": 12,
+				"y": 42
+			},
+			"id": 176,
+			"options": {
+				"legend": {
+					"calcs": [],
+					"displayMode": "list",
+					"placement": "bottom"
+				},
+				"tooltip": {
+					"mode": "single"
+				}
+			},
+			"targets": [
+				{
+					"datasource": {
+						"type": "prometheus",
+						"uid": "PEDE6B306CC9C0CD0"
+					},
+					"exemplar": true,
+					"expr": "storage_level_compact_read_sstn_next",
+					"interval": "",
+					"legendFormat": "",
+					"refId": "A"
+				}
+			],
+			"title": "count of sst read from next level",
+			"type": "timeseries"
+		},
 		{
 			"collapsed": false,
 			"gridPos": {
@@ -7647,6 +7741,6 @@
 	"timezone": "",
 	"title": "risingwave_dashboard",
 	"uid": "Ecy3uV1nz",
-	"version": 32,
+	"version": 33,
 	"weekStart": ""
 }
diff --git a/src/meta/src/hummock/metrics_utils.rs b/src/meta/src/hummock/metrics_utils.rs
@@ -17,6 +17,7 @@ use std::time::{SystemTime, UNIX_EPOCH};
 
 use itertools::enumerate;
 use prometheus::core::{AtomicF64, AtomicU64, GenericCounter};
+use prost::Message;
 use risingwave_pb::hummock::{CompactMetrics, HummockVersion, TableSetStatistics};
 
 use crate::hummock::compaction::CompactStatus;
@@ -31,6 +32,9 @@ pub fn trigger_commit_stat(metrics: &MetaMetrics, current_version: &HummockVersi
         .iter()
         .fold(0, |accum, elem| accum + elem.tables.len());
     metrics.uncommitted_sst_num.set(uncommitted_sst_num as i64);
+    metrics
+        .version_size
+        .set(current_version.encoded_len() as i64);
 }
 
 pub fn trigger_sst_stat(

diff --git a/src/meta/src/rpc/metrics.rs b/src/meta/src/rpc/metrics.rs
@@ -57,6 +57,8 @@ pub struct MetaMetrics {
     pub level_compact_write_sstn: IntCounterVec,
     /// num of compactions from each level to next level
     pub level_compact_frequency: IntCounterVec,
+    /// hummock version size
+    pub version_size: IntGauge,
 }
 
 impl MetaMetrics {
@@ -163,6 +165,9 @@ impl MetaMetrics {
         )
         .unwrap();
 
+        let version_size =
+            register_int_gauge_with_registry!("version_size", "version size", registry).unwrap();
+
         Self {
             registry,
 
@@ -180,6 +185,7 @@ impl MetaMetrics {
             level_compact_read_sstn_next,
             level_compact_write_sstn,
             level_compact_frequency,
+            version_size,
         }
     }