Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(hummock): add hummock version size metric #2348

Merged
merged 1 commit into from
May 6, 2022

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented May 6, 2022

No description provided.

@hzxa21 hzxa21 requested a review from soundOfDestiny May 6, 2022 07:43
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #2348 (f24d6d3) into main (0193870) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
- Coverage   71.07%   71.05%   -0.02%     
==========================================
  Files         675      675              
  Lines       84502    84566      +64     
==========================================
+ Hits        60061    60091      +30     
- Misses      24441    24475      +34     
Flag Coverage Δ
rust 71.05% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/hummock/metrics_utils.rs 96.32% <100.00%> (+0.08%) ⬆️
src/meta/src/rpc/metrics.rs 79.24% <100.00%> (+0.53%) ⬆️
src/meta/src/hummock/hummock_manager.rs 88.62% <0.00%> (-2.61%) ⬇️
src/meta/src/hummock/vacuum.rs 83.18% <0.00%> (-2.08%) ⬇️
src/common/src/types/ordered_float.rs 24.70% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@soundOfDestiny soundOfDestiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy! Since we have encoded_len()

@hzxa21 hzxa21 merged commit 484c941 into main May 6, 2022
@hzxa21 hzxa21 deleted the patrick/version-size-metrics branch May 6, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants