Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): use all-in-one binary #1067

Merged
merged 5 commits into from
Mar 18, 2022
Merged

feat(ci): use all-in-one binary #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8107b38
feat(ci): use all-in-one binary
skyzh Mar 18, 2022
a44fe33
fix build
skyzh Mar 18, 2022
12f1b39
fix build
skyzh Mar 18, 2022
24d3780
fix build
skyzh Mar 18, 2022
53ebe6b
fix build
skyzh Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 22 additions & 52 deletions .github/workflow-template/template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,22 +83,10 @@ jobs:
distribution: "adopt"

- uses: actions/download-artifact@v2
name: Download compute-node binary
name: Download risingwave binary
with:
name: compute-node
path: ./.risingwave/bin

- uses: actions/download-artifact@v2
name: Download meta-node binary
with:
name: meta-node
path: ./.risingwave/bin

- uses: actions/download-artifact@v2
name: Download rust frontend binary
with:
name: frontend-v2
path: ./.risingwave/bin
name: risingwave
path: ./rust/target/debug

- uses: actions/download-artifact@v2
name: Download frontend binary
Expand All @@ -114,9 +102,7 @@ jobs:

- name: Adjust permission
run: |
chmod +x ./.risingwave/bin/meta-node
chmod +x ./.risingwave/bin/compute-node
chmod +x ./.risingwave/bin/frontend-v2
chmod +x ./rust/target/debug/risingwave
chmod +x ./rust/target/debug/risedev-playground
- name: Install required components
Expand Down Expand Up @@ -144,7 +130,9 @@ jobs:
mv ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl ~/cargo-make
- name: Prepare RiseDev playground
run: ~/cargo-make/makers pre-start-playground
run: |
~/cargo-make/makers link-all-in-one-binaries
~/cargo-make/makers pre-start-playground
# --- Tests ---
#
Expand Down Expand Up @@ -274,16 +262,10 @@ jobs:
mv ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl ~/cargo-make
- uses: actions/download-artifact@v2
name: Download compute-node binary
with:
name: compute-node
path: ./.risingwave/bin

- uses: actions/download-artifact@v2
name: Download meta-node binary
name: Download risingwave binary
with:
name: meta-node
path: ./.risingwave/bin
name: risingwave
path: ./rust/target/debug

- uses: actions/download-artifact@v2
name: Download frontend binary
Expand All @@ -305,8 +287,7 @@ jobs:

- name: Adjust permission
run: |
chmod +x ./.risingwave/bin/meta-node
chmod +x ./.risingwave/bin/compute-node
chmod +x ./rust/target/debug/risingwave
chmod +x ./rust/target/debug/risedev-playground
chmod +x ./rust/target/debug/risingwave_regress_test
Expand All @@ -319,7 +300,9 @@ jobs:
cp risedev-components.ci.env risedev-components.user.env
- name: Prepare RiseDev playground
run: ~/cargo-make/makers pre-start-playground
run: |
~/cargo-make/makers link-all-in-one-binaries
~/cargo-make/makers pre-start-playground
# --- Tests ---
#
Expand Down Expand Up @@ -468,40 +451,27 @@ jobs:
- name: Run rust cargo-sort check
run: |
make rust_cargo_sort_check
cd rust && cargo sort -c -w
- name: Run rust format check
run: |
make rust_fmt_check
cd rust && cargo fmt --all -- --check
- name: Run rust clippy check
run: |
# If new CI checks are added, the one with `--locked` must be run first.
make rust_clippy_check_locked
- name: Build compute-node and meta-node
run: make rust_build

- uses: actions/upload-artifact@v2
with:
name: compute-node
if-no-files-found: error
path: |
rust/target/debug/compute-node
cd rust && cargo clippy --all-targets --locked -- -D warnings
- uses: actions/upload-artifact@v2
with:
name: meta-node
if-no-files-found: error
path: |
rust/target/debug/meta-node
- name: Build Rust components
run: |
cd rust && cargo build --features=all-in-one
- uses: actions/upload-artifact@v2
with:
name: frontend-v2
name: risingwave
if-no-files-found: error
path: |
rust/target/debug/frontend-v2
rust/target/debug/risingwave
- uses: actions/upload-artifact@v2
with:
Expand Down
69 changes: 22 additions & 47 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,20 +79,10 @@ jobs:
java-version: "11"
distribution: "adopt"
- uses: actions/download-artifact@v2
name: Download compute-node binary
name: Download risingwave binary
with:
name: compute-node
path: ./.risingwave/bin
- uses: actions/download-artifact@v2
name: Download meta-node binary
with:
name: meta-node
path: ./.risingwave/bin
- uses: actions/download-artifact@v2
name: Download rust frontend binary
with:
name: frontend-v2
path: ./.risingwave/bin
name: risingwave
path: ./rust/target/debug
- uses: actions/download-artifact@v2
name: Download frontend binary
with:
Expand All @@ -105,9 +95,7 @@ jobs:
path: ./rust/target/debug
- name: Adjust permission
run: |
chmod +x ./.risingwave/bin/meta-node
chmod +x ./.risingwave/bin/compute-node
chmod +x ./.risingwave/bin/frontend-v2
chmod +x ./rust/target/debug/risingwave
chmod +x ./rust/target/debug/risedev-playground
- name: Install required components
run: |
Expand All @@ -130,7 +118,9 @@ jobs:
unzip ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl.zip -d ~
mv ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl ~/cargo-make
- name: Prepare RiseDev playground
run: ~/cargo-make/makers pre-start-playground
run: |
~/cargo-make/makers link-all-in-one-binaries
~/cargo-make/makers pre-start-playground
- name: e2e test streaming 3-node
timeout-minutes: 2
run: |
Expand Down Expand Up @@ -234,15 +224,10 @@ jobs:
unzip ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl.zip -d ~
mv ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl ~/cargo-make
- uses: actions/download-artifact@v2
name: Download compute-node binary
with:
name: compute-node
path: ./.risingwave/bin
- uses: actions/download-artifact@v2
name: Download meta-node binary
name: Download risingwave binary
with:
name: meta-node
path: ./.risingwave/bin
name: risingwave
path: ./rust/target/debug
- uses: actions/download-artifact@v2
name: Download frontend binary
with:
Expand All @@ -260,8 +245,7 @@ jobs:
path: ./rust/target/debug
- name: Adjust permission
run: |
chmod +x ./.risingwave/bin/meta-node
chmod +x ./.risingwave/bin/compute-node
chmod +x ./rust/target/debug/risingwave
chmod +x ./rust/target/debug/risedev-playground
chmod +x ./rust/target/debug/risingwave_regress_test
- name: Run batch tests on Postgresql
Expand All @@ -271,7 +255,9 @@ jobs:
run: |
cp risedev-components.ci.env risedev-components.user.env
- name: Prepare RiseDev playground
run: ~/cargo-make/makers pre-start-playground
run: |
~/cargo-make/makers link-all-in-one-binaries
~/cargo-make/makers pre-start-playground
- name: regress test batch 3-node
run: |
~/cargo-make/makers clean-data
Expand Down Expand Up @@ -395,34 +381,23 @@ jobs:
cargo install cargo-sort
- name: Run rust cargo-sort check
run: |
make rust_cargo_sort_check
cd rust && cargo sort -c -w
- name: Run rust format check
run: |
make rust_fmt_check
cd rust && cargo fmt --all -- --check
- name: Run rust clippy check
run: |
# If new CI checks are added, the one with `--locked` must be run first.
make rust_clippy_check_locked
- name: Build compute-node and meta-node
run: make rust_build
- uses: actions/upload-artifact@v2
with:
name: compute-node
if-no-files-found: error
path: |
rust/target/debug/compute-node
- uses: actions/upload-artifact@v2
with:
name: meta-node
if-no-files-found: error
path: |
rust/target/debug/meta-node
cd rust && cargo clippy --all-targets --locked -- -D warnings
- name: Build Rust components
run: |
cd rust && cargo build --features=all-in-one
- uses: actions/upload-artifact@v2
with:
name: frontend-v2
name: risingwave
if-no-files-found: error
path: |
rust/target/debug/frontend-v2
rust/target/debug/risingwave
- uses: actions/upload-artifact@v2
with:
name: risingwave_regress_test
Expand Down
69 changes: 22 additions & 47 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,20 +80,10 @@ jobs:
java-version: "11"
distribution: "adopt"
- uses: actions/download-artifact@v2
name: Download compute-node binary
name: Download risingwave binary
with:
name: compute-node
path: ./.risingwave/bin
- uses: actions/download-artifact@v2
name: Download meta-node binary
with:
name: meta-node
path: ./.risingwave/bin
- uses: actions/download-artifact@v2
name: Download rust frontend binary
with:
name: frontend-v2
path: ./.risingwave/bin
name: risingwave
path: ./rust/target/debug
- uses: actions/download-artifact@v2
name: Download frontend binary
with:
Expand All @@ -106,9 +96,7 @@ jobs:
path: ./rust/target/debug
- name: Adjust permission
run: |
chmod +x ./.risingwave/bin/meta-node
chmod +x ./.risingwave/bin/compute-node
chmod +x ./.risingwave/bin/frontend-v2
chmod +x ./rust/target/debug/risingwave
chmod +x ./rust/target/debug/risedev-playground
- name: Install required components
run: |
Expand All @@ -131,7 +119,9 @@ jobs:
unzip ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl.zip -d ~
mv ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl ~/cargo-make
- name: Prepare RiseDev playground
run: ~/cargo-make/makers pre-start-playground
run: |
~/cargo-make/makers link-all-in-one-binaries
~/cargo-make/makers pre-start-playground
- name: e2e test streaming 3-node
timeout-minutes: 2
run: |
Expand Down Expand Up @@ -235,15 +225,10 @@ jobs:
unzip ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl.zip -d ~
mv ~/cargo-make-v0.35.7-x86_64-unknown-linux-musl ~/cargo-make
- uses: actions/download-artifact@v2
name: Download compute-node binary
with:
name: compute-node
path: ./.risingwave/bin
- uses: actions/download-artifact@v2
name: Download meta-node binary
name: Download risingwave binary
with:
name: meta-node
path: ./.risingwave/bin
name: risingwave
path: ./rust/target/debug
- uses: actions/download-artifact@v2
name: Download frontend binary
with:
Expand All @@ -261,8 +246,7 @@ jobs:
path: ./rust/target/debug
- name: Adjust permission
run: |
chmod +x ./.risingwave/bin/meta-node
chmod +x ./.risingwave/bin/compute-node
chmod +x ./rust/target/debug/risingwave
chmod +x ./rust/target/debug/risedev-playground
chmod +x ./rust/target/debug/risingwave_regress_test
- name: Run batch tests on Postgresql
Expand All @@ -272,7 +256,9 @@ jobs:
run: |
cp risedev-components.ci.env risedev-components.user.env
- name: Prepare RiseDev playground
run: ~/cargo-make/makers pre-start-playground
run: |
~/cargo-make/makers link-all-in-one-binaries
~/cargo-make/makers pre-start-playground
- name: regress test batch 3-node
run: |
~/cargo-make/makers clean-data
Expand Down Expand Up @@ -396,34 +382,23 @@ jobs:
cargo install cargo-sort
- name: Run rust cargo-sort check
run: |
make rust_cargo_sort_check
cd rust && cargo sort -c -w
- name: Run rust format check
run: |
make rust_fmt_check
cd rust && cargo fmt --all -- --check
- name: Run rust clippy check
run: |
# If new CI checks are added, the one with `--locked` must be run first.
make rust_clippy_check_locked
- name: Build compute-node and meta-node
run: make rust_build
- uses: actions/upload-artifact@v2
with:
name: compute-node
if-no-files-found: error
path: |
rust/target/debug/compute-node
- uses: actions/upload-artifact@v2
with:
name: meta-node
if-no-files-found: error
path: |
rust/target/debug/meta-node
cd rust && cargo clippy --all-targets --locked -- -D warnings
- name: Build Rust components
run: |
cd rust && cargo build --features=all-in-one
- uses: actions/upload-artifact@v2
with:
name: frontend-v2
name: risingwave
if-no-files-found: error
path: |
rust/target/debug/frontend-v2
rust/target/debug/risingwave
- uses: actions/upload-artifact@v2
with:
name: risingwave_regress_test
Expand Down
Loading