fix(dashboard v2): fix some bugs #1084
Conversation
|
Still reading docs to deal with 404 fallback in the axum backend. These are some essential issues affecting common usage. |
dashboard/package.json
Outdated
| @@ -4,7 +4,8 @@ | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "start": "next start", | |||
| "build-static": "next export" | |||
| "build-static": "next export", | |||
| "build-prod": "next export && rm -rf ../.risingwave/ui && rm -rf ui && cp -r out ui && mv ui ../.risingwave" | |||
There was a problem hiding this comment.
I'd prefer not to hardcode the path for PREFIX_UI. Maybe update Makefile.toml with a new task:
e.g.
[tasks.export-dashboard-v2]
script = """
rm -rf "${PREFIX_UI}"
cd dashboard && npm run build-prod
cd .. && ln -s dashboard/out ${PREFIX_UI}
"""and we write...
"build-prod": "next export"
There was a problem hiding this comment.
sure. I'll take it look :)
There was a problem hiding this comment.
... wait a minute, I think any change to PREFIX_UI directory will be over-written by tasks.extract-dashboard-artifact...
What about having a Build dashboard from source option in riselab-config? I might add that next week.
There was a problem hiding this comment.
Yes. It will be over-written by risedev. Currently we need to run build-prod after risedev is activated. Using Build dashboard from source is more convenient.
There was a problem hiding this comment.
emm, seems building dashboard from source is not so convenient for development. Since every time we want to test with meta node, we need to shut down the risingwave and reboot it, and then run some tests.... It is better to have a script which can replace the current built artifact in runtime.
There was a problem hiding this comment.
We can use first use ./risedev d to start the cluster (which calls export-dashboard-v2 for the first time). Then, we may use ./risedev export-dashboard-v2 to rebuild dashboard, without restarting the meta node. Does this sound good?
There was a problem hiding this comment.
Implemented in #1086, you make take a look :)
There was a problem hiding this comment.
Sure. I think it is convenient enough now :)
| @@ -36,6 +36,18 @@ The website will be served at port 3000. | |||
| npm run dev | |||
| ``` | |||
|
|
|||
| ## Test with risingwave meta node | |||
There was a problem hiding this comment.
Please also help removing Dashboard section in README.md, and instruct users to take a look at the README.md under dashboard folder.
What's changed and what's your intention?
Checklist