feat(risedev): add build dashboard config #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
2 tasks
Signed-off-by: Alex Chi <[email protected]>
skyzh
force-pushed
the
skyzh/add-dashboard-risedev-config
branch
from
44f15c9 to
cae9f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Chi [email protected]
What's changed and what's your intention?
RiseDev will now export
ENABLE_BUILD_DASHBOARD_V2env variable if we want to build dashboard v2.Dashboard developer will need to update Makefile.toml to build or git checkout the dashboard artifact.I've supported it along with this PR.Also, the env file will have more information on each option.
Checklist
Refer to a related PR or issue link (optional)