Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove epoch service in meta #2554

Merged
merged 1 commit into from
May 16, 2022
Merged

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented May 16, 2022

What's changed and what's your intention?

As title.

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

Resolve #2553

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥰

@yezizp2012 yezizp2012 enabled auto-merge (squash) May 16, 2022 05:22
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #2554 (623ddcc) into main (e6fecc7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2554   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files         689      688    -1     
  Lines       88521    88512    -9     
=======================================
  Hits        63215    63215           
+ Misses      25306    25297    -9     
Flag Coverage Δ
rust 71.41% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/meta/src/rpc/server.rs 0.00% <ø> (ø)
src/meta/src/rpc/service/mod.rs 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 merged commit c71a063 into main May 16, 2022
@yezizp2012 yezizp2012 deleted the refactor/rm-epoch-srv branch May 16, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta: remove EpochService
3 participants