Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove epoch service in meta #2554

Merged
merged 1 commit into from
May 16, 2022
Merged

refactor: remove epoch service in meta #2554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions proto/meta.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,6 @@ message Schema {
uint64 version = 3;
}

// Below for epoch service.

message GetEpochRequest {}

message GetEpochResponse {
common.Status status = 1;
uint64 epoch = 2;
}

service EpochService {
rpc GetEpoch(GetEpochRequest) returns (GetEpochResponse);
}

// Below for catalog service.
// will be deprecated and replaced by DdlService
message CreateRequest {
Expand Down
1 change: 0 additions & 1 deletion src/meta/src/rpc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ mod service;
pub use service::catalog_service::CatalogServiceImpl;
pub use service::cluster_service::ClusterServiceImpl;
pub use service::ddl_service::DdlServiceImpl;
pub use service::epoch_service::EpochServiceImpl;
pub use service::heartbeat_service::HeartbeatServiceImpl;
pub use service::hummock_service::HummockServiceImpl;
pub use service::notification_service::NotificationServiceImpl;
Expand Down
3 changes: 0 additions & 3 deletions src/meta/src/rpc/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ use risingwave_pb::ddl_service::ddl_service_server::DdlServiceServer;
use risingwave_pb::hummock::hummock_manager_service_server::HummockManagerServiceServer;
use risingwave_pb::meta::catalog_service_server::CatalogServiceServer;
use risingwave_pb::meta::cluster_service_server::ClusterServiceServer;
use risingwave_pb::meta::epoch_service_server::EpochServiceServer;
use risingwave_pb::meta::heartbeat_service_server::HeartbeatServiceServer;
use risingwave_pb::meta::notification_service_server::NotificationServiceServer;
use risingwave_pb::meta::stream_manager_service_server::StreamManagerServiceServer;
Expand All @@ -43,7 +42,6 @@ use crate::manager::{CatalogManager, MetaOpts, MetaSrvEnv, StoredCatalogManager}
use crate::rpc::metrics::MetaMetrics;
use crate::rpc::service::catalog_service::CatalogServiceImpl;
use crate::rpc::service::cluster_service::ClusterServiceImpl;
use crate::rpc::service::epoch_service::EpochServiceImpl;
use crate::rpc::service::heartbeat_service::HeartbeatServiceImpl;
use crate::rpc::service::hummock_service::HummockServiceImpl;
use crate::rpc::service::stream_service::StreamServiceImpl;
Expand Down Expand Up @@ -255,7 +253,6 @@ pub async fn rpc_serve_with_store<S: MetaStore>(
.add_service(ClusterServiceServer::new(cluster_srv))
.add_service(StreamManagerServiceServer::new(stream_srv))
.add_service(HummockManagerServiceServer::new(hummock_srv))
.add_service(EpochServiceServer::new(EpochServiceImpl::default()))
.add_service(NotificationServiceServer::new(notification_srv))
.add_service(DdlServiceServer::new(ddl_srv))
.serve_with_incoming_shutdown(
Expand Down
37 changes: 0 additions & 37 deletions src/meta/src/rpc/service/epoch_service.rs
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/meta/src/rpc/service/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
pub mod catalog_service;
pub mod cluster_service;
pub mod ddl_service;
pub mod epoch_service;
pub mod heartbeat_service;
pub mod hummock_service;
pub mod notification_service;
Expand Down