chore(ci): remove unused e2e test #2616
Conversation
| - name: Run batch tests on Postgresql | ||
| timeout-minutes: 10 | ||
| run: | | ||
| sqllogictest -p ${{ env.PG_PORT }} './e2e_test/batch/**/*.slt' | ||
|
|
There was a problem hiding this comment.
Do not know why e2e-source has a test on PG. Looks unnecessary so delete. cc @shanicky @tabVersion
There was a problem hiding this comment.
This is used by regression test?
There was a problem hiding this comment.
It's to make ensure that we have the same query result as pg, I think it's necessary.
There was a problem hiding this comment.
No. If regression tests, it should be runned by RW and PG at the same time. However RW is not.
There was a problem hiding this comment.
No, it's not used by regression test.
| - name: Run batch tests on Postgresql | ||
| timeout-minutes: 10 | ||
| run: | | ||
| sqllogictest -p ${{ env.PG_PORT }} './e2e_test/batch/**/*.slt' | ||
|
|
There was a problem hiding this comment.
This is used by regression test?
| - name: Run batch tests on Postgresql | ||
| timeout-minutes: 10 | ||
| run: | | ||
| sqllogictest -p ${{ env.PG_PORT }} './e2e_test/batch/**/*.slt' | ||
|
|
Codecov Report
@@ Coverage Diff @@
## main #2616 +/- ##
==========================================
- Coverage 72.33% 72.33% -0.01%
==========================================
Files 678 678
Lines 88225 88225
==========================================
- Hits 63821 63820 -1
- Misses 24404 24405 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
LGTM |
What's changed and what's your intention?
Remove batch/streaming e2e test first.
Next step will rename the v2 tests into first class citizen
Checklist
Refer to a related PR or issue link (optional)