Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove unused e2e test #2616

Merged
merged 2 commits into from
May 18, 2022
Merged

chore(ci): remove unused e2e test #2616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
704e7d4
chore(ci): remove unused e2e test
BowenXiao1999 May 18, 2022
8a05510
revert some tests that should not be delete
BowenXiao1999 May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflow-template/jobs/e2e-source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,6 @@ jobs:
chmod +x ./target/debug/risedev-playground
chmod +x ./target/debug/risingwave_regress_test

- name: Run batch tests on Postgresql
timeout-minutes: 10
run: |
sqllogictest -p ${{ env.PG_PORT }} './e2e_test/batch/**/*.slt'

Comment on lines -97 to -101
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not know why e2e-source has a test on PG. Looks unnecessary so delete. cc @shanicky @tabVersion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by regression test?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @liurenjie1024

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to make ensure that we have the same query result as pg, I think it's necessary.

Copy link
Contributor Author

@BowenXiao1999 BowenXiao1999 May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. If regression tests, it should be runned by RW and PG at the same time. However RW is not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not used by regression test.

- name: Generate RiseDev CI config
run: |
cp risedev-components.ci.env risedev-components.user.env
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/main-cron.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,10 +292,6 @@ jobs:
chmod +x ./target/debug/risingwave
chmod +x ./target/debug/risedev-playground
chmod +x ./target/debug/risingwave_regress_test
- name: Run batch tests on Postgresql
timeout-minutes: 10
run: |
sqllogictest -p ${{ env.PG_PORT }} './e2e_test/batch/**/*.slt'
- name: Generate RiseDev CI config
run: |
cp risedev-components.ci.env risedev-components.user.env
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,10 +438,6 @@ jobs:
chmod +x ./target/debug/risingwave
chmod +x ./target/debug/risedev-playground
chmod +x ./target/debug/risingwave_regress_test
- name: Run batch tests on Postgresql
timeout-minutes: 10
run: |
sqllogictest -p ${{ env.PG_PORT }} './e2e_test/batch/**/*.slt'
- name: Generate RiseDev CI config
run: |
cp risedev-components.ci.env risedev-components.user.env
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,6 @@ jobs:
chmod +x ./target/debug/risingwave
chmod +x ./target/debug/risedev-playground
chmod +x ./target/debug/risingwave_regress_test
- name: Run batch tests on Postgresql
timeout-minutes: 10
run: |
sqllogictest -p ${{ env.PG_PORT }} './e2e_test/batch/**/*.slt'
- name: Generate RiseDev CI config
run: |
cp risedev-components.ci.env risedev-components.user.env
Expand Down
2 changes: 1 addition & 1 deletion dashboard/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ TODO: Find a suitable testing framework
Start the RisingWave database.
```bash
./risedev d
sqllogictest -p 4567 './e2e_test/streaming/tpch/tpch.slt'
sqllogictest -p 4567 './e2e_test/v2/**/**.slt'
```
Install Dependencies.
```bash
Expand Down
13 changes: 0 additions & 13 deletions e2e_test/batch/aggregate/avg.slt
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions e2e_test/batch/aggregate/count.slt
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions e2e_test/batch/aggregate/minmax.slt
View file
Open in desktop

This file was deleted.

Empty file removed e2e_test/batch/aggregate/sum.slt
View file
Open in desktop
Empty file.
Loading