perf(hummock manager): store incremental hummock version in meta #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soundOfDestiny
force-pushed
the
zl_incver
branch
from
ae2cd9f to
139eb1e
Compare
wenym1
reviewed
Jun 27, 2022
soundOfDestiny
force-pushed
the
zl_incver
branch
from
139eb1e to
87a969a
Compare
Codecov Report
@@ Coverage Diff @@
## main #3503 +/- ##
==========================================
+ Coverage 74.46% 74.48% +0.01%
==========================================
Files 769 770 +1
Lines 108052 108126 +74
==========================================
+ Hits 80466 80541 +75
+ Misses 27586 27585 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
soundOfDestiny
force-pushed
the
zl_incver
branch
from
bc1ca3b to
065f2c0
Compare
| prev_id: old_version.id, | ||
| ..Default::default() | ||
| }, | ||
| ); | ||
| let mut new_hummock_version = |
There was a problem hiding this comment.
do we need to remove VarTransaction for hummock_versions
There was a problem hiding this comment.
do we need to remove
VarTransactionforhummock_versions
I wanted to remove it in the future
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
store incremental hummock version in meta
it will replace hummock version
Checklist
Refer to a related PR or issue link (optional)