refactor(hummock manager): load mem hummock version with version delt… #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3529 +/- ##
==========================================
- Coverage 74.45% 74.44% -0.01%
==========================================
Files 770 770
Lines 108517 108600 +83
==========================================
+ Hits 80792 80850 +58
- Misses 27725 27750 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
soundOfDestiny
force-pushed
the
zl_appdelta
branch
10 times, most recently
from
7317ac8 to
b272f6f
Compare
soundOfDestiny
force-pushed
the
zl_appdelta
branch
from
b272f6f to
7ef0e7f
Compare
…a instead of version
soundOfDestiny
force-pushed
the
zl_appdelta
branch
2 times, most recently
from
78536a0 to
b80ec6e
Compare
soundOfDestiny
force-pushed
the
zl_appdelta
branch
from
b80ec6e to
58c174e
Compare
src/storage/hummock_sdk/src/compaction_group/hummock_version_ext.rs
Outdated
Show resolved
Hide resolved
soundOfDestiny
force-pushed
the
zl_appdelta
branch
from
73abb8b to
bef73b6
Compare
|
Would we clean deltas in another PR? |
here is a scheme: is this OK? |
No, it is not enough. If the meta-node lives a long time without restarts, we may append a lot of |
This was referenced Jun 30, 2022
huangjw806
pushed a commit
that referenced
this pull request
Jul 5, 2022
#3529) * refactor(hummock manager): load mem hummock version with version delta instead of version * add hummock version apply trait * refactor apply_compact_result * hide_l0_remove_pos Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a instead of version
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
load mem hummock version with version delta instead of version
rebuild version from version deltas
this PR is successor of #3503
Checklist
Refer to a related PR or issue link (optional)