Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): expose Vnode function as __rw_vnode for easy debugging #4327

Merged
merged 3 commits into from
Aug 1, 2022
Merged

feat(frontend): expose Vnode function as __rw_vnode for easy debugging #4327

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02cb8cc
expose internal `vnode` function as `__rw_vnode` for debugging
stdrc Aug 1, 2022
91d6b54
add e2e test for `__rw_vnode` just to make sure the function runs
stdrc Aug 1, 2022
241c90a
Merge branch 'main' into rc/expose-vnode-function-for-debugging
mergify[bot] Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions e2e_test/batch/functions/internal.slt.part
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
statement ok
SET RW_IMPLICIT_FLUSH TO true;

statement ok
create table t(v1 varchar, v2 int, v3 int)

statement ok
select __rw_vnode(_row_id) as vnode, _row_id from t;

statement ok
insert into t values ('aaa', 1, 1), ('bbb', 0, 2), ('ccc', 0, 5), ('ddd', 1, 4)

statement ok
select __rw_vnode(_row_id) as vnode, _row_id from t;

statement ok
drop table t
1 change: 1 addition & 0 deletions src/frontend/src/binder/expr/function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ impl Binder {
"current_database" if inputs.is_empty() => {
return Ok(ExprImpl::literal_varchar(self.db_name.clone()));
}
"__rw_vnode" => ExprType::Vnode,
_ => {
return Err(ErrorCode::NotImplemented(
format!("unsupported function: {:?}", function_name),
Expand Down