feat(frontend): expose Vnode function as __rw_vnode for easy debugging
#4327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdrc
changed the title
__rw_vnode for easy debuggingVnode function as __rw_vnode for easy debugging
Codecov Report
@@ Coverage Diff @@
## main #4327 +/- ##
=======================================
Coverage 74.33% 74.33%
=======================================
Files 844 844
Lines 122445 122446 +1
=======================================
+ Hits 91019 91020 +1
Misses 31426 31426
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lmatz
approved these changes
Aug 1, 2022
stdrc
added
type/feature
component/frontend
|
I think prefix it with |
3 tasks
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
…gging (risingwavelabs#4327) * expose internal `vnode` function as `__rw_vnode` for debugging * add e2e test for `__rw_vnode` just to make sure the function runs Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Expose
Vnodefunction as__rw_vnodefor debug purpose.Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
#4262 (review)