feat(risedev): support 3 compute nodes in playground

[BugenZhao]

Signed-off-by: Bugen Zhao [email protected]

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. Used lazy_static for shared in-memory object store.

To start this:

PLAYGROUND_PROFILE=playground-3cn ./risedev p

Checklist

• I have written necessary rustdoc comments
• I have added necessary unit tests and integration tests
• All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

Close #4195.

[skyzh]

Need to add compactor?

[BugenZhao]

Need to add compactor?

Both LGTM.

[wenym1]

I think we should add a feature in the crate to enable this.

[BugenZhao]

This function should not be used by default, so SHARED should not be initialized and there's no side effect. Adding a feature for this may make playground deployment complicated. 🥵

[BugenZhao]

Added explicit notes for this and make it private outside the super module.

[codecov]

Codecov Report

Merging #4332 (dc85d22) into main (650221e) will decrease coverage by 0.01%.
The diff coverage is 2.56%.

@@            Coverage Diff             @@
##             main    #4332      +/-   ##
==========================================
- Coverage   74.32%   74.31%   -0.02%     
==========================================
  Files         844      844              
  Lines      122474   122496      +22     
==========================================
  Hits        91027    91027              
- Misses      31447    31469      +22     

Flag	Coverage Δ
rust	74.31% <2.56%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/cmd_all/src/bin/risingwave.rs	2.63% <0.00%> (ø)
src/object_store/src/object/mod.rs	37.36% <0.00%> (-0.60%)	⬇️
src/risedevtool/src/risectl_env.rs	0.00% <0.00%> (ø)
src/risedevtool/src/task/compactor_service.rs	0.00% <0.00%> (ø)
src/risedevtool/src/task/compute_node_service.rs	0.00% <0.00%> (ø)
src/risedevtool/src/task/utils.rs	0.00% <0.00%> (ø)
src/object_store/src/object/mem.rs	84.90% <12.50%> (-3.33%)	⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[skyzh]

Also I’m wondering how many compactors are started indeed. For in-memory mode, every compute node will start a compactor. So maybe we have started 4?

[BugenZhao]

Also I’m wondering how many compactors are started indeed. For in-memory mode, every compute node will start a compactor. So maybe we have started 4?

Oops, seems to be a problem. What's the optimal solution? How about disabling compactor in compute node under shared in-memory mode?

[skyzh]

Oops, seems to be a problem. What's the optimal solution? How about disabling compactor in compute node under shared in-memory mode?

Can we make compactor to start with object store instance in in-memory mode?

[BugenZhao]

Can we make compactor to start with object store instance in in-memory mode?

Currently it does, so we've started 4. 🤣 Let's do not start compactor in shared in-memory mode, behaving like minio/s3?

https://github.com/singularity-data/risingwave/blob/61c0104e7755e28f9f13a2d122d50982e326c89e/src/compute/src/server.rs#L145-L151

[skyzh]

Let's do not start compactor in shared in-memory mode, behaving like minio/s3?

Looks good. So we'll need a flag to tell each node whether to enable compactor or not.

Note that we also have another edge case. When risedev.yml is not present, playground mode should start a compactor thread along with compute node.

https://github.com/singularity-data/risingwave/blob/7d1c0b6d6f91873fd00a6f92e6b8d7ad37d3e632/src/cmd_all/src/playground.rs#L108-L113