feat(test): support killing all kinds of node in deterministic e2e test #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4969 +/- ##
==========================================
+ Coverage 74.02% 74.21% +0.19%
==========================================
Files 877 877
Lines 134077 134064 -13
==========================================
+ Hits 99245 99491 +246
+ Misses 34832 34573 -259
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
wangrunji0408
force-pushed
the
wrj/kill-meta
branch
from
2341fc2 to
4dff06f
Compare
9 tasks
Signed-off-by: Runji Wang <[email protected]>
BugenZhao
approved these changes
Aug 31, 2022
| @@ -156,7 +174,7 @@ async fn main() { | |||
| ]); | |||
| risingwave_compute::start(opts).await | |||
| }); | |||
| if args.kill_node { | |||
| if args.kill_compute || args.kill_meta { | |||
There was a problem hiding this comment.
Should the compactor also restart on meta restarts? 🤔
There was a problem hiding this comment.
Not tested yet. I will add this to compactor if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
Like #4332, we made the meta in-memory store shared, so that data won't lose after restart.
Temporarily disabled recovery test on CI because it's unstable. Tracking issue: #4527.
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)