Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): rename __rw_vnode to rw_vnode #4342

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 1, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Little renaming.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#4327 (comment)

@stdrc stdrc requested a review from fuyufjh August 1, 2022 11:20
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #4342 (bbdf0b5) into main (c87f9b5) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4342   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         843      843           
  Lines      122713   122713           
=======================================
  Hits        91316    91316           
  Misses      31397    31397           
Flag Coverage Δ
rust 74.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/binder/expr/function.rs 80.15% <100.00%> (ø)
src/meta/src/manager/id.rs 95.65% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@stdrc stdrc requested a review from st1page August 1, 2022 13:15
@mergify mergify bot merged commit e2d0c42 into main Aug 2, 2022
@mergify mergify bot deleted the rc/rename-vnode-function branch August 2, 2022 03:36
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
…#4342)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants